projectblacklight / blacklight

91%

master: 49%

LAST BUILD ON BRANCH ignore_empty_facet_query_param

branch: ignore_empty_facet_query_param

CHANGE BRANCH

x

Reset

• ignore_empty_facet_query_param
• 1138-graceful-degrade
• 1186-repository-find-order
• 1278-search-session
• 1328-view-context
• 1362-negative-facet-limit
• 1393-fix-solr-generator
• 1451-bookmarks-post
• 1471-triple-equals
• 1476-yard-tags
• 1491-search_builder_spec
• 1492-search-builder-ex
• 1553-facet-align
• 1554-li-dropdown
• 1576-migration-compat
• 1620-modal-order
• 1631-show-tools
• 1666-hash-deprecations
• 1680-json-api-rel-alternate
• 1682-opensearch
• 1686-view-type-display-control
• 1846-fix-facet-collapse-bug
• 1848-modal-form-submit
• 1910-search-state
• 5.1-backport
• 5.x-fix-blacklight-catalog-load
• 5.x-search-builder
• 520-remove-saved-searches
• 6.x-do-not-update-checkbox
• 6.x-rails42
• 6x-symbol-regression
• abstract_repo
• ac-parameters
• accessibility-fixes
• action-framework
• action-view-logging
• action_builder
• action_dispatch
• add-icons
• add-missing-pagination-keys
• add-project-solr-wrapper-file
• add-semantic-classes
• add_comment
• add_docs
• adjust-responsive-layout
• aggregations
• ajax_modal_double_submit
• ajax_modal_failure
• akretion-master
• allow_dots
• allow_newer_webdriver
• allow_rsolr2
• am-shim
• and_or
• api
• app-concerns
• app-template
• application_record
• arity-check
• array-conditions
• asset-generators
• asset-url
• assets
• attributes_on_classes
• autocomplete
• autofocus
• autoload
• autoload_not_needed
• avoid_unnecessary_lookup
• back_to_nil
• backport
• backport-1982
• backport-2220-role-menu-item
• backport-5.0
• backport-attributes
• backport-html-change
• backport-sass-rails-req
• backport-session-doc-id
• backport_1806
• backport_autocomplete
• backport_cast_nil_fix
• backport_facet_404
• backport_search_state_controller
• backports
• bare-partials
• benchmark-logger
• benchmarkable
• better-buttons
• binary-columns
• bkeese-issue-1080
• bl-es
• blacklight-adapter
• blacklight-document
• blacklight-field-key
• blacklight-index-seed
• blacklight-install-options
• blacklight-logger
• blacklight-marc-5.x
• blacklight-marc-install
• blacklight-solr
• blacklist_empty
• bloodhound
• bookmarks-constraints
• bookmarks_checkbox_bootstrap_fix
• bookmarks_export
• bookmarks_export_helpers
• bookmarks_export_ideas
• bookmarks_export_index
• bootstrap-4-a6
• bootstrap-4b3
• bootstrap-fixes
• bootstrap-metatag
• bootstrap-sprockets
• bootstrap4
• bootstrap4-constraints
• break-normal
• bribe_the_cop
• bs-beta
• bs4a5
• build_bundle
• bump-dependencies
• bump_rails
• bump_versions
• cache-key
• camel_case
• capybara3
• card-body
• card-styling
• catalog-track
• catalog_show_col_sm
• cbeer-patch-1
• cbeer-patch-2
• cbeer-patch-3
• ch-facet-count
• check-task
• chromedriver
• cjcolvar-bookmark-actions-refactor
• cleanup_search_results
• cleanup_style
• code-tidying
• config-fixes
• config_collection
• config_dir
• config_search_state
• config_to_json
• configurable-containers
• configurable-select-error
• configurable-select-error-backport
• configurable-show-classes
• configurable_pipeline
• configuration_for_type
• configure_navbar
• connection-config
• consolidate-helpers
• consolidate_search
• controller-configuration-context
• correct_documentation
• coverage
• coveralls
• custom-facet-value-nil
• date-escape
• db-migrations
• debug_partial_paths
• decompose_utils
• decouple-blacklight-from-marc
• deep-dup
• default-operator
• default-processor-chain
• default_translation
• dependency-versions
• deprecate-conditions
• deprecate-duplicative-ivars
• deprecate-label
• deprecate-solr-doc-ids-params
• deprecate_default_per_page_helper
• deprecate_delegation
• deprecate_facet_list_limit
• deprecate_false
• deprecate_get_document
• deprecate_get_facet_pagination
• deprecate_get_solr_response_for_document_ids
• deprecate_render_index_field_value
• deprecate_single_doc
• deprecated-search-state
• deprecated_constant_proxy
• deprecation-context
• deprecation-warnings
• deprecation_details
• deprecations
• deserialize-search-state
• desolrize
• dev-updates
• devise33
• disable-thumbnail-link
• do-not-update-checkbox
• doc-equality
• doc-presenter-field
• doc-title-classes
• doc_solr_helper
• docker-solr
• docker-travis
• docs
• document
• document-actions
• document-classes
• document-counter-css
• document-delegate
• document-fetch
• document-pagination-params
• document_factory
• document_heading
• document_index_views
• document_presenter
• documents-class
• dont-deep-dup-classes
• dont-memoize
• dot_position_consistency
• drop-rails-5-0
• drop_solr_field
• dry_default_sort_field
• dual-assignment
• duplicate_test
• dynamic-fields
• eager_autoload
• ec10
• elasticsearch
• elasticsearch-2
• email-config
• encapsulate_force_to_utf8
• engine-cart-0.3
• engine-cart-080
• engine-cart-fingerprint
• engine_cart
• engine_cart_080
• engine_cart_update
• error_handling
• expand-api-tests
• extract-search-session
• extract_encrypted_user
• extract_export_formats
• extract_scss
• facet-count-formatting
• facet-field-limit
• facet-field-names
• facet-fields
• facet-index-navigation
• facet-key-field
• facet-key-params
• facet-more-limit
• facet-params
• facet-refactor
• facet-remove
• facet-rendering
• facet_groups
• facet_limit
• facet_list_presenter
• facet_not_found
• facet_paginiator_cast_error
• facet_params_default_sort
• facets_from_request
• faster_build
• favicon-link-tag
• fetch_adapter
• fetch_many_document_params
• fewer-conditionals
• field-config-if-defaults
• field-match
• field-specific-solr-config
• field_values
• fix-5x-build
• fix-autocomplete
• fix-bookmark-export
• fix-build
• fix-es
• fix-helper-expectation
• fix-quoting-error
• fix-sass-rails
• fix-saved-searches-link-style
• fix-search-builder
• fix-solr-65
• fix-suggest
• fix-zero-results
• fix_alignment
• fix_facebook
• fix_indent
• fix_indenting
• fix_js
• fix_js_backport
• fix_matrix
• fix_paginator
• fix_refworks
• fix_show_endnote_export
• fix_style
• fix_styles
• fixup_jetty_generator
• fluent-pagination
• format_user
• fq-class
• freeze-document
• frozen
• frozen_string_literals
• gemspec
• generate_search_builder
• generators
• generic_repository
• globalid
• google-site-links
• graceful-prev-next-doc-errors
• grouping
• hackmastera-backport-i18n
• hash-access-methods
• hash-key
• headers
• headless-chrome
• helper-loading
• helpers-cleanup
• hide-per-page-0
• hide_fetch_many
• home-intro
• home-text
• html-escape
• html5
• hyphen_styles
• i#1871
• i#1872
• i#910
• i18n
• i18n-fields
• ie-html5shim
• if-unless
• image_url
• improve_test
• improved_constraint
• include_in_request
• indentation_consitency
• indentation_consitency_normal
• indentation_width
• independent_facet_field_in_params
• index-document-export
• index-response-formats
• index_tools_partials_config
• indifferent-hash-access
• input-types
• is-bookmarked
• issue-757
• issue-813
• issue-833
• issue-868
• issue-872
• issue-904
• issue-956
• issue-958
• issue-968
• issue-983
• issues-795
• java-version-check
• jbuilder
• jcoyne-patch-1
• jcoyne-patch-2
• jetty-port
• jetty_version
• jruby-9.2
• jshintrc
• json-api
• json-type
• json_index_attributes
• label-typos
• labels
• lat-lon
• layout
• layouts
• license
• link-purpose
• link_alternate_url_for_doc
• link_rel_alternates
• link_tags
• link_to_facet
• loosen_rsolr
• major-bootstrap
• make-the-zs-smaller
• master
• mejackreed-patch-1
• memoize_search_builder
• method_missing
• min-ruby-ver
• mjgiarlo-patch-1
• mlt
• modal-6.x
• modularize_search_builder
• more-fixes
• more-inclusive-count-selector
• more-specific-selector
• more_on_limited_facets
• more_than_two_pages
• move-refworks-endnote
• move_exception_handling
• move_has_search_parameters
• move_method
• move_templates
• multiple-semantics
• multiple-semantics-6x
• multiple-title-fields
• multivalued-render-fields
• new_options
• no-blank-thumbnail
• no-bundle-cache
• no-pin-bundler
• no_delegate
• no_devise_helper
• no_double_escape
• no_exceptions
• no_html_as_js
• no_id_selectors
• no_string_keys
• noswha
• npm-update
• opensearch-sym
• optimize_config_lookup
• optionally-disable-turbolinks
• os-hash-key
• ostruct
• override_document_partial_name
• p-y
• page-titles
• partial-name-with-base-name-arg
• pass_no_html_argument
• peetucket-facet-filter-index
• per-page
• percent-regex
• pin-webdriver
• pin_rubocop
• pin_rubocop_rspec
• ping
• plugin_test_setup
• point_fields
• polymorphic-session-tracking-path
• possible-bad-facet-name-fix
• preferred_view
• presenter-deprecation
• presenter-factory
• presenters_in_api
• prev_next_in_search_session
• primary-key
• private
• private_render_filtered
• processor_chain_manipulation
• proper-json
• protect_addtl_respns
• qt-solr
• query-logging
• query-solr-find
• rails-19419
• rails-42
• rails-5.1
• rails-matrix
• rails41rc2
• rails42
• rails4_1
• rails5
• rails5-dev
• rails5-prep
• rails5.rc2
• rails5b3
• rails_4.2.1
• raise-error
• raise_no_method_error
• raw-endpoint
• raw-term
• readme-fixes
• real-time-get
• recent_solr
• record_search_parameters
• reduce_abc_complexity
• redundant_freeze
• redundant_self
• refactor-config
• refactor_component_config
• refactor_doc_presenter
• refactor_generator
• refactor_index_view
• refactor_link_to_document
• refactor_render_constraints_query
• refactor_search_results
• refactor_spec
• refactor_specs
• reflect_fields
• relative_paths
• relax_kaminari
• release-5.0
• release-5.1
• release-5.10
• release-5.10-backports
• release-5.11
• release-5.11-backports
• release-5.14
• release-5.5
• release-5.9
• release-5.9-backports
• release-5.x
• release-5.x-backports
• release-5.x-build
• release-6.19.2
• release-6.x
• release-6.x-backports
• release-6.x-backports2
• release-6.x-field-values
• released_devise
• remove-add-routes
• remove-ar-keys
• remove-constraints-link
• remove-deprecated-behavior
• remove-deprecated-code
• remove-deprecated-keys
• remove-discard-flash
• remove-extra-french-keys
• remove-facet-fields
• remove-jettywrapper
• remove-link
• remove-methods
• remove-modal-form
• remove-more-key
• remove-panel-body
• remove-polyfills
• remove-rails40
• remove-redundant-class
• remove-require
• remove-symlink
• remove-unnecessary-route
• remove-unnecessary-route2
• remove-unused-images
• remove-unused-separator-config-in-test
• remove_autofocus
• remove_const
• remove_default
• remove_deprecation
• remove_empty
• remove_exemption
• remove_extra_space
• remove_facet_list_limit
• remove_filters
• remove_globalid
• remove_i18n
• remove_layout
• remove_marc_demo
• remove_protected_attributes
• remove_search_facet_url
• remove_solr4_support
• remove_unnecessary_conditional
• remove_unused_file
• remove_unused_method
• remove_whitespace
• rename_modal
• rename_solr_repository
• render-document-heading
• render-helper-method-config
• render_facet_limit_list
• render_filter_element_strings
• render_partials_helper
• req-dependencies
• request_builders
• require_dependency
• resourceful-routing
• results-bar
• routing-spec
• rows-fix
• rsolr-2x
• rsolr11
• rspec
• rspec-2.99
• rspec-include-text
• rspec3
• rspec35
• rss-atom
• rubocop
• rubocop-specs
• rubocop-violations
• ruby-2.3
• ruby-version
• ruby1.9-find_solr_document
• ruby19-hash
• ruby2
• ruby_2_1_1
• sanitize_sort
• sass-deps
• sass-rails
• saved-search
• saved_searches_concern
• scss_files
• search-builder
• search-builder-param
• search-builder-scope
• search-builder-where
• search-field-label-with-no-field
• search-form-styling-fix
• search-input-addon
• search-label
• search-session-routing
• search-state
• search-state-clone
• search-suggest-action
• search-suggest-model
• search-urls
• search-width
• search_action_url
• search_bar_presenter
• search_builder
• search_builder_refactor
• search_facet_path
• search_history
• search_service
• search_state
• search_state_routes
• secret-key
• separate-overlapping-icon-toggle
• session_filter_on_index
• settable_pipeline_operations
• shared_views
• show-field-config
• show-field-labels
• silence-deprecations
• simple_404_for_record_not_found
• simplecov
• simplify_render_constraints_query
• simplify_search_state
• simplify_track
• simplify_view_spec
• skip-defining-show-methods
• skip_solr
• skip_turbolinks_precheck
• smaller_results_columns
• sms-carrier-fix
• sms-id
• sms-route
• solr-4.10.4
• solr-7.1
• solr-7.2
• solr-8-conf
• solr-doc-model
• solr-doc-ruby-19
• solr-document-class
• solr-repository
• solr-search-builder
• solr4-jettywrapper
• solr5
• solr_response_logger
• solr_schema
• solr_update
• solrdoc-route-scope
• sort
• sort-fields
• space_style
• spec
• spellcheck-q
• sprockets-fix-5x
• sprockets-rails-fix
• standard-filter
• static-deprecation-warning
• strip_heredoc
• strip_heredocs
• stub-deprecations
• style-search
• stylesheet-all-media
• stylistic
• successful
• suggestions
• support-rails-5
• suppress_link
• svg-icons
• template
• test-cleanup
• test-rails-5.1
• test_5.2.beta
• test_link_to_previous
• test_rails
• test_rails5
• test_rails_5.1
• thumbnail-field-array
• thumbnail_config
• thumbnail_presenter
• tidy-code
• time-zone-now
• timestamps-null
• to-sentence
• to_sym
• token-based-user
• track_click
• travis
• travis-build
• travis-ci
• travis-ci-pruning
• travis-gems
• travis-matrix
• turbolinks-5-patch
• turbolinks-loader
• typeahead
• typeahead-zindex
• underscore_unused_args
• unneeded-interpolation
• unpin_capybara
• unsupported
• update-mocks
• update-rsolr
• update-rubocop
• update_doc_and_double
• update_doc_and_double_master
• update_grid
• update_rails
• update_rubocop
• update_rubocop_todo
• update_template
• upgrade_rubocop
• url-for-document
• url-for-document-helper
• url-helpers
• use-lib-general-purpose
• use-solr-default-dynamic
• use_facet_field_label
• use_html
• use_jbuilder
• useless-assignment
• v5-backports
• v5.0.0
• v5.0.0.pre4
• v5.0.1
• v5.0.2
• v5.0.3
• v5.1.0
• v5.1.1
• v5.10
• v5.10.0
• v5.10.1
• v5.10.2
• v5.10.3
• v5.11.0
• v5.11.1
• v5.11.2
• v5.11.3
• v5.12.0
• v5.12.1
• v5.13.0
• v5.13.1
• v5.14.0
• v5.15.0
• v5.16.0
• v5.16.1
• v5.16.2
• v5.16.3
• v5.16.4
• v5.17.0
• v5.17.1
• v5.17.2
• v5.18.0
• v5.19.0
• v5.19.1
• v5.19.2
• v5.2.0
• v5.3.0
• v5.4.0
• v5.4.0.rc1
• v5.5.0
• v5.5.1
• v5.5.2
• v5.5.3
• v5.5.4
• v5.6.0
• v5.7.0
• v5.7.1
• v5.8.0
• v5.8.2
• v5.9.0
• v5.9.2
• v5.9.3
• v5.9.4
• v6.0.0
• v6.0.0.pre1
• v6.0.0.pre2
• v6.0.0.pre3
• v6.0.0.pre4
• v6.0.0.pre5
• v6.0.2
• v6.1.0
• v6.10.0
• v6.10.1
• v6.11.0
• v6.11.1
• v6.11.2
• v6.12.0
• v6.13.0
• v6.14.0
• v6.14.1
• v6.15.0
• v6.16.0
• v6.17.0
• v6.18.0
• v6.19.0
• v6.19.1
• v6.19.2
• v6.2.0
• v6.20.0
• v6.21.0
• v6.22.0
• v6.3.0
• v6.3.1
• v6.3.2
• v6.3.3
• v6.4.0
• v6.4.1
• v6.4.2
• v6.5.0
• v6.6.0
• v6.6.1
• v6.6.2
• v6.7.0
• v6.7.1
• v6.7.2
• v6.7.3
• v6.8.0
• v6.9.0
• v7.0.0.rc1
• v7.0.0.rc2
• vagrant
• view-config
• view-config-document-actions
• view-label
• view-preference
• webpack
• without_should
• yard_see
• zero_monkeypatch

Build # 1445

Build Type

push

travis-ci

Committed by jrochkind

Commit Message

Ignore empty f[facet][] query param

Previously this would result in a limit being applied
for a facet with an empty string value. I don't think this
is a real use case (it would be somewhat tricky to index
values in Solr this way even if you wanted to), and I
don't think this was intentional.

Seems better to ignore empty facet limit query params
like that, have them be no-ops that do not effect
the Solr query or the visible constraints. That's
what this does.

empty facet limit query params of course shouldn't happen
at all, and are probably mistakes, but could come from:
* a bug in some part of BL or plugin
* a bug in some external "deep link generating" tool
* user error manipulating the URL manually

I suggest it's better to have such a mistake be a no-op, then
to have it result in odd and disconcerting behavior as previous.

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

2693 of 2953 relevant lines covered (91.2%)

6490.55 hits per line