• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

projectblacklight / blacklight / 1445
91%
master: 49%

Build:
Build:
LAST BUILD BRANCH: release-6.x
DEFAULT BRANCH: master
Ran 29 May 2014 03:09PM UTC
Jobs 9
Files 131
Run time 26min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1445

push

travis-ci

jrochkind
Ignore empty f[facet][] query param

Previously this would result in a limit being applied
for a facet with an empty string value. I don't think this
is a real use case (it would be somewhat tricky to index
values in Solr this way even if you wanted to), and I
don't think this was intentional.

Seems better to ignore empty facet limit query params
like that, have them be no-ops that do not effect
the Solr query or the visible constraints. That's
what this does.

empty facet limit query params of course shouldn't happen
at all, and are probably mistakes, but could come from:
* a bug in some part of BL or plugin
* a bug in some external "deep link generating" tool
* user error manipulating the URL manually

I suggest it's better to have such a mistake be a no-op, then
to have it result in odd and disconcerting behavior as previous.

2 of 2 new or added lines in 2 files covered. (100.0%)

2693 of 2953 relevant lines covered (91.2%)

6490.55 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1445.1 (2.1.1, gemfiles/rails3.gemfile) 29 May 2014 03:09PM UTC 0
91.17
Travis Job 1445.1
2 1445.2 (2.1.1, gemfiles/rails4.gemfile) 29 May 2014 03:10PM UTC 0
91.09
Travis Job 1445.2
3 1445.3 (2.1.1, gemfiles/rails4.1.gemfile) 29 May 2014 03:10PM UTC 0
91.09
Travis Job 1445.3
4 1445.4 (2.0.0, gemfiles/rails3.gemfile) 29 May 2014 03:10PM UTC 0
91.17
Travis Job 1445.4
5 1445.5 (2.0.0, gemfiles/rails4.gemfile) 29 May 2014 03:11PM UTC 0
91.09
Travis Job 1445.5
6 1445.6 (2.0.0, gemfiles/rails4.1.gemfile) 29 May 2014 03:20PM UTC 0
91.09
Travis Job 1445.6
7 1445.7 (2.1.0, gemfiles/rails4.gemfile) 29 May 2014 03:22PM UTC 0
91.09
Travis Job 1445.7
8 1445.8 (1.9.3, gemfiles/rails4.gemfile) 29 May 2014 03:23PM UTC 0
91.26
Travis Job 1445.8
9 1445.9 (jruby, gemfiles/rails4.gemfile) 29 May 2014 03:35PM UTC 0
88.7
Travis Job 1445.9
Source Files on build 1445
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1445
  • a97b1ad1 on github
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc