playwright-community / playwright-go

79%

main: 79%

LAST BUILD ON BRANCH pr/jsonpipe-deadlock

branch: pr/jsonpipe-deadlock

CHANGE BRANCH

x

Reset

• pr/jsonpipe-deadlock
• add-logger-override-support
• add-only-install-shell-option
• align-with-upstream-client
• chore/gitignore-claude
• chore/update-github-actions
• ci-fail
• ci/concurrency-cancel-prs-only
• dataRace
• docs-cli-ver
• docs/fix-readme-and-contributing
• expose-redirected-navigation-request
• feat/assemble-driver-from-npm-and-nodejs
• feat/flakiness-io-reporter
• fix-sizes-panic
• fix-tests
• fix/579-expect-download-mobile-test
• fix/connection-deadlocks
• fix/dispatcher-event-handler-deadlock
• fix/evaluate-handle-element-panic
• fix/event-emitter-lock-across-handlers
• fix/handle-parsing-float
• fix/locator-evaluate-attached-state
• fix/remote-upload-flake
• fix/request-header-shape
• fix/response-null-structured-results
• fix/set-input-files-default-timeout
• fix/test_worker
• fix/waiter_deadlock
• fix/webkit-folder-upload-timeout-180s
• main
• misuse-matrix
• mxschmitt/budapest
• mxschmitt/columbus
• mxschmitt/dallas-v2
• mxschmitt/kyiv-v4
• mxschmitt/macau-v1
• mxschmitt/victoria-v1
• patch-1
• patch-2
• patch-nilerror
• pr/event-handler-deadlock
• roll-v1.49.1
• roll-v1.50
• roll-v1.51
• roll-v1.52
• roll/v1.59.1
• roll/v1.60.0
• roll/v1.61.1
• tidy-1.57
• update-dependency

Build # 28145332481

Build Type

Pull #602

github

Committed by mxschmitt

Commit Message

refactor: use sync.Cond for jsonPipe queue; support multiple consumers

Address review feedback on the deadlock fix:
- Replace the hand-rolled buffered-signal-channel + wake() condvar with
  sync.Cond over the existing mutex. This is the idiomatic primitive for
  'wait until queue non-empty or closed', removes the load-bearing
  non-blocking-send/re-check-loop subtlety, and drops ~15 lines.
- Broadcast instead of a single-token signal, so multiple concurrent
  Poll() consumers are supported (the old single-token design would have
  stranded messages if a second consumer were ever added).
- Consolidate the triplicated deadlock rationale into one comment on
  enqueue (the invariant owner).
- Rework TestJsonPipeEnqueueNeverBlocks to also drain and assert ordering
  after the burst, and add TestJsonPipeMultipleConsumers to cover the
  exactly-once delivery guarantee.

Pull Request Pull Request #602: fix: prevent jsonPipe deadlock that hung remote connections

Coverage Stats

27 of 30 new or added lines in 1 file covered. (90.0%)

1 existing line in 1 file now uncovered.

7946 of 10121 relevant lines covered (78.51%)

5884.73 hits per line