playwright-community / playwright-go

78%

main: 79%

LAST BUILD ON BRANCH pr/event-handler-deadlock

branch: pr/event-handler-deadlock

CHANGE BRANCH

x

Reset

• pr/event-handler-deadlock
• add-logger-override-support
• add-only-install-shell-option
• align-with-upstream-client
• chore/gitignore-claude
• chore/update-github-actions
• ci-fail
• ci/concurrency-cancel-prs-only
• dataRace
• docs-cli-ver
• docs/fix-readme-and-contributing
• expose-redirected-navigation-request
• feat/assemble-driver-from-npm-and-nodejs
• feat/flakiness-io-reporter
• fix-sizes-panic
• fix-tests
• fix/579-expect-download-mobile-test
• fix/connection-deadlocks
• fix/dispatcher-event-handler-deadlock
• fix/evaluate-handle-element-panic
• fix/event-emitter-lock-across-handlers
• fix/handle-parsing-float
• fix/locator-evaluate-attached-state
• fix/remote-upload-flake
• fix/request-header-shape
• fix/response-null-structured-results
• fix/set-input-files-default-timeout
• fix/test_worker
• fix/waiter_deadlock
• fix/webkit-folder-upload-timeout-180s
• main
• misuse-matrix
• mxschmitt/budapest
• mxschmitt/columbus
• mxschmitt/dallas-v2
• mxschmitt/kyiv-v4
• mxschmitt/macau-v1
• mxschmitt/victoria-v1
• patch-1
• patch-2
• patch-nilerror
• pr/jsonpipe-deadlock
• roll-v1.49.1
• roll-v1.50
• roll-v1.51
• roll-v1.52
• roll/v1.59.1
• roll/v1.60.0
• roll/v1.61.1
• tidy-1.57
• update-dependency

Build # 28146667280

Build Type

Pull #603

github

Committed by mxschmitt

Commit Message

fix: guard against nil callback on unknown reply id in Dispatch

Dispatch ignored the loaded bool from callbacks.LoadAndDelete and
dereferenced cb.noReply directly. A reply whose id has no pending
callback (duplicate or unknown reply) would deref a nil
*protocolCallback and panic the dispatch goroutine. Upstream throws
"Cannot find command to respond"; guard and ignore the stray reply.

This becomes more reachable with the re-entrant pump, which runs
Dispatch from inside a blocking call made in an event handler.

Pull Request Pull Request #603: fix: prevent deadlock when calling blocking methods inside event handlers

Coverage Stats

45 of 73 new or added lines in 3 files covered. (61.64%)

15 existing lines in 1 file now uncovered.

7978 of 10181 relevant lines covered (78.36%)

6858.32 hits per line