playwright-community / playwright-go

79%

main: 79%

LAST BUILD ON BRANCH fix/connection-deadlocks

branch: fix/connection-deadlocks

CHANGE BRANCH

x

Reset

• fix/connection-deadlocks
• add-logger-override-support
• add-only-install-shell-option
• align-with-upstream-client
• chore/gitignore-claude
• chore/update-github-actions
• ci-fail
• ci/concurrency-cancel-prs-only
• dataRace
• docs-cli-ver
• docs/fix-readme-and-contributing
• expose-redirected-navigation-request
• feat/assemble-driver-from-npm-and-nodejs
• feat/flakiness-io-reporter
• fix-sizes-panic
• fix-tests
• fix/579-expect-download-mobile-test
• fix/dispatcher-event-handler-deadlock
• fix/evaluate-handle-element-panic
• fix/event-emitter-lock-across-handlers
• fix/handle-parsing-float
• fix/locator-evaluate-attached-state
• fix/remote-upload-flake
• fix/request-header-shape
• fix/response-null-structured-results
• fix/set-input-files-default-timeout
• fix/test_worker
• fix/waiter_deadlock
• fix/webkit-folder-upload-timeout-180s
• main
• misuse-matrix
• mxschmitt/budapest
• mxschmitt/columbus
• mxschmitt/dallas-v2
• mxschmitt/kyiv-v4
• mxschmitt/macau-v1
• mxschmitt/victoria-v1
• patch-1
• patch-2
• patch-nilerror
• pr/event-handler-deadlock
• pr/jsonpipe-deadlock
• roll-v1.49.1
• roll-v1.50
• roll-v1.51
• roll-v1.52
• roll/v1.59.1
• roll/v1.60.0
• roll/v1.61.1
• tidy-1.57
• update-dependency

Build # 28143035874

Build Type

Pull #601

github

Committed by mxschmitt

Commit Message

fix: prevent jsonPipe deadlock that hung remote connections

The remote-connection transport (jsonPipe) delivered incoming messages into
a bounded channel (buffer 10) from the outer connection's dispatch goroutine.
When more than 10 messages queued before the inner connection drained them,
that blocking send stalled the dispatch goroutine — which is also the only
goroutine that delivers replies. Any in-flight Send() awaiting a reply then
blocked forever.

This surfaced as a flaky hang in TestShouldUploadAFolderRemote: streaming
files to a remote server produces a burst of write/close responses plus async
page events, occasionally exceeding the buffer and deadlocking until the test
timeout. Reproduced deterministically by shrinking the buffer to 1; goroutine
dump showed the dispatch goroutine blocked on 'chan send' at jsonPipe while the
test goroutine blocked on 'chan receive' in jsonPipe.Send.

Replace the bounded channel with an unbounded, order-preserving queue drained
by Poll(), so the dispatch goroutine never blocks. Add unit tests covering the
non-blocking guarantee, ordering, blocking Poll, close, and drain-before-close.

Pull Request Pull Request #601: fix: eliminate the two remaining connection-layer deadlocks (event-handler + jsonPipe)

Coverage Stats

78 of 92 new or added lines in 4 files covered. (84.78%)

7981 of 10166 relevant lines covered (78.51%)

6018.37 hits per line