penguinolog / urwid
70%
master: 73%

LAST BUILD BRANCH: pre_4013
DEFAULT BRANCH: master
Repo Added
Token nZ5xt2o2DKKtMXKnDA1uXfKzjCCxuWXzE regen
Build 760 Last
Files 63
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH sizing_fixes
branch: sizing_fixes
CHANGE BRANCH
x
Sync Branches

coverage: 69.933% (+0.1%) from 69.806%
32853930287

push

travis-pro

penguinolog 
Fix sizing related issues

## Fixes
- **`Overlay`: oversized `width=PACK` no longer raises `WidgetError`.**
  `render()` passed the negative `left`/`right` padding to `CanvasOverlay` as a *position*,
  shifting the already-trimmed top canvas off the left edge
  and producing a canvas wider than the requested size.
  The padding itself is left untouched
  (negative values are the correct coordinate model for clipped content,
  and `mouse_event`/`get_cursor_coords` rely on it);
  only the overlay position is clamped.
- **`Overlay`: `PACK` height is measured at the width the top widget actually gets**
  (`maxcol - left - right`) instead of the overlay's full width.
  Fixes wrong vertical centring and dead mouse clicks below wrapped text.
  Since `render`, `keypress`, `mouse_event` and `get_cursor_coords`
  all route through `calculate_padding_filler`,
  all four become consistent, and it now agrees with `Overlay.rows()`.
  Fixes #471.
- **`Canvas.set_pop_up`: enforces its documented preconditions.**
  `left`/`top` `>= 0` and `overlay_width`/`overlay_height` `> 0`
  were documented but unchecked,
  so bad values either silently mis-placed the pop-up
  or surfaced later as a bare `ValueError: 0`.
  Now raises `CanvasError` with a clear message.
- **`Filler.sizing()`: warns when a `PACK` height is paired with a non-FLOW body.**
  Such a `Filler` declared `{BOX, FLOW}`
  but failed at *every* size with an opaque
  `AttributeError: '…' object has no attribute 'rows'`.
  Follows the existing `Padding.sizing()` pattern
  (warn via the new `FillerWarning`, returned set unchanged).
  Relates to #247.
- **`PopUpLauncher.create_pop_up`: documents that the pop-up must accept a box size**,
  since `PopUpTarget` always overlays with `GIVEN`/`GIVEN`.
  Previously a flow pop-up failed with an unexplained
  `ValueError: too many values to unpack`.

3082 of 4974 branches covered (61.96%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

8636 of 11782 relevant lines covered (73.3%)

7.5 hits per line

Relevant lines Covered
11782 RELEVANT LINES 8636 COVERED LINES
7.5 HITS PER LINE
Source Files on sizing_fixes

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32853930287 sizing_fixes Fix sizing related issues ## Fixes - **`Overlay`: oversized `width=PACK` no longer raises `WidgetError`.** `render()` passed the negative `left`/`right` padding to `CanvasOverlay` as a *position*, shifting the already-trimmed top canvas off t... push penguinolog travis-pro
69.93
See All Builds (700)

Badge your Repo: urwid

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh