ovh / utask

71%

master: 57%

LAST BUILD ON BRANCH fix-db-config-default

branch: fix-db-config-default

CHANGE BRANCH

x

Reset

• fix-db-config-default
• Dockerfile
• add-comment-while-manual-actions
• advanced-watchers
• api-output-yaml
• auto-resume-parent-task-after-sub-task-complete
• automate-release
• backoff
• backoff-refactor
• bump-golang-1.14
• chained-foreach
• changelog
• changelog-150
• chore-ui-lib
• ci-build-dockerimage
• clear-release
• collection-operators
• configstore-squash-config-items
• custom-dashboard-path-prefix
• dashboard-refacto
• db-config-name
• dependabot/npm_and_yarn/ui/dashboard/acorn-6.4.1
• dependabot/npm_and_yarn/ui/dashboard/elliptic-6.5.3
• dependabot/npm_and_yarn/ui/dashboard/jquery-3.5.0
• dependabot/npm_and_yarn/ui/dashboard/lodash-4.17.19
• dependabot/npm_and_yarn/ui/dashboard/npm-registry-fetch-4.0.5
• dependabot/npm_and_yarn/ui/dashboard/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/ui/editor/acorn-6.4.1
• dependabot/npm_and_yarn/ui/editor/elliptic-6.5.3
• dependabot/npm_and_yarn/ui/editor/handlebars-4.5.3
• dependabot/npm_and_yarn/ui/editor/jquery-3.5.0
• dependabot/npm_and_yarn/ui/editor/lodash-4.17.19
• dependabot/npm_and_yarn/ui/editor/npm-registry-fetch-8.1.1
• dependabot/npm_and_yarn/ui/editor/socket.io-2.4.1
• dependabot/npm_and_yarn/ui/editor/websocket-extensions-0.1.4
• dependencies
• dev/rbeuque/configstore-defaultstore
• dev/rbeuque/fix-auth-identity-ctx-key
• dev/rbeuque/fix-conf-ui-prefix
• dev/rbeuque/fix-dashboard-no-auth
• dev/rbeuque/fix-notify-no-backends
• dev/rbeuque/fix-subtask-foreach-templating
• dev/rbeuque/fix-task-blocked-resolution-running
• dev/rbeuque/functions
• dev/rbeuque/http-mtls
• dev/rbeuque/improve-ci-and-build
• dev/rbeuque/json-marshal
• dev/rbeuque/json-schema
• dev/rbeuque/maintenance-mode-run-resolution
• dev/rbeuque/marshal-html-tags
• dev/rbeuque/sql
• dev/ybriffa/dev/ybriffa/preHook
• dev/ybriffa/digestAuthAndUUID
• dev/ybriffa/fixEchoUnmarshal
• dev/ybriffa/master
• dev/ybriffa/output
• dev/ybriffa/preHook
• dev/ybriffa/services
• dev/ybriffa/unmarshalEcho
• development-workflow
• display-subtask-as-toretry
• documentation-tags-resources
• edit-resolution
• email-plugin-noauth
• engine-consistent-donecount
• feat-http-cookies-and-auth-bearer
• feat-step-hooks
• feat/configurable-max-body-bytes
• feat/prometheus-stats
• feat/task-stats-page
• feat/ux-dashboard-children
• featHttpMagicPrefix
• fieldFrom
• filter-task
• fix-ci
• fix-deadlock-prerun-foreach
• fix-deepcopy-values
• fix-goreleaser
• fix-http-plugin
• fix-init-plugins-load
• fix-log
• fix-missing-input
• fix-modules
• fix-multiple-template-import-subtasks
• fix-new-task
• fix-normalize-templates
• fix-pipe-date
• fix-script-plugin
• fix-subtask-exec-error
• fix-subtask-tag
• fix-subtask-templating
• fix/build-dashboard-ngxchips
• fix/template-load-error-msg
• fix/ui-dashboard-ergo
• fixes
• foreach-output-with-state
• fromJSON-func
• get-resolution
• handler-rbac
• http-auth
• http-plugin-fixes
• http-timeout-default
• improve-coverage
• improve-documentation
• improve-error-msgs
• improve-goreleaser
• improve-goreport
• improve-issue-templates
• improve-ssh
• ineffassign
• insecure-skip-verify-http
• instance-collector
• json-marshal
• master
• migration-005
• misc-ssh-scripts
• notification-strategies
• notification-webhook
• output-marshal-error
• ping
• plugin-example
• pull-request-template
• readme-license
• readme-template
• refactor-ant-design
• release
• remove-templates-if-not-existing-anymore
• remove-vendor
• removing-step-payload
• resolution-autorun
• resolver-inputs-in-task
• resource-acquisition
• rework-email
• rlt-chore-release-utask-lib
• rlt-feat-all-task-filter
• rlt-feat-filter-template
• rlt-fix-utask-style
• script-plugin
• script-refacto
• sma-bad-request-messages
• sma-dashboard-multilines
• sma-ui-form-task
• sma-using-lib
• sma/fix/ui-dependencies
• smartine-fix-ui
• smartine-ui-refresh-home
• smartinez-bad-request-messages
• smartinez-dashboard-multilines
• smartinez-fix-dashboard
• smartinez-ui-resolvable-tasks
• smartinez/fix/ui-dependencies
• sql-indexes
• sql-migration-checker
• ssh-close-conn
• step-lint-circular-deps
• subtask-output
• swagger-path-prefix
• task-tags
• templating-empty-values
• templating-state
• typo
• v0.0.1
• v1.0.2
• v1.1.0
• v1.10.0
• v1.11.0
• v1.2.0
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.5
• v1.2.6
• v1.3.0
• v1.3.1
• v1.3.2
• v1.4.0
• v1.4.1
• v1.4.2
• v1.5.0
• v1.5.1
• v1.5.2
• v1.6.0
• v1.6.1
• v1.7.0
• v1.8.0
• v1.8.1
• v1.8.2
• v1.8.3
• v1.8.4
• v1.9.0
• v1.9.1
• v1.9.2
• v1.test
• validate-input-variables
• variable-value-templated
• variables-in-task-title-format

Build # 837

Build Type

Pull #110

travis-ci

Committed by web-flow

Commit Message

fix: unmarshaling of database config can lead to wrong default values

The fields MaxOpenConns, MaxIdleConns, ConnMaxLifetime are set to the
zero-value of their type during unmarshaling when no input value is
provided in the configuration, which lead to the default values not
being used. Replace the fields with pointers to distinguish the zero
value and use the default when appropriate.

Signed-off-by: William Poussier <william.poussier@gmail.com>

Pull Request Pull Request #110: fix: unmarshaling of database config can lead to wrong default values

Run Details

1378 of 1946 relevant lines covered (70.81%)

58.17 hits per line