oracle / oci-cloud-controller-manager

35%

master: 36%

LAST BUILD ON BRANCH pr/HadrienPatte/log-format

branch: pr/HadrienPatte/log-format

CHANGE BRANCH

x

Reset

Sync Branches

• pr/HadrienPatte/log-format
• dependabot/go_modules/github.com/docker/distribution-2.8.2incompatible
• dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/sys-0.1.0
• dependabot/go_modules/golang.org/x/text-0.3.8
• documentation-updates
• jah/filter-backend-nodes
• jlamillan/increase-timeout
• jlamillan/match-complete-hostnames
• l-technicore-patch-1
• lb-name-caching
• master
• oke-119-pending
• oke-oss-minor-releasse-branch-commits
• oke-oss-releaes_1.26.4
• oke-oss-release-1.25.0
• oke-oss-release-1.26.1-latest-sdk
• oke-oss-release-1.26.3
• oke-oss-release-1.29.2
• oke-oss-release-1.30.2
• oke-oss-release-1.31.1
• oke-oss-release-v1.22.0
• oke-oss-release-v1.23.0
• oke-oss-release-v1.24.0
• oke-oss-release-v1.27.1
• oke-oss-release-v1.27.2
• oke-oss-release-v1.28.0
• oke-oss-release-v1.28.2
• oke-oss-release-v1.29.1
• oke-oss-release-v1.30.0
• oke-oss-release-v1.32.2
• oke-oss-release-v1.33.1
• oke-oss-release-v1.34.0
• oke-oss-release_1.24.0
• oke-oss-release_1.24.1
• oke-oss-release_1.25.1
• oke-oss-release_1.26.0
• oke-oss-release_1.27.3
• oke-oss-release_1.28.1
• oke-oss-release_1.29.0
• oke-oss-release_1.30.1
• oke-oss-release_1.31.0
• oke-pending-changes
• oke_oss_release_1.25.2
• oke_oss_release_1.26
• oke_oss_release_1.27.0
• oss-master
• oss-oke-nlb-k8-119
• oss/release-1.34.1
• oss/release-1.34.2
• oss/wris-clients
• pr/HadrienPatte/gofmt
• pr/HadrienPatte/test-optimization
• pr/flex-cidr-allocator
• publish-manifests
• pvt/lustre-oss
• pvt/lustre-oss-1.31
• pvt/lustre-oss-1.33
• raw_block_vol_v1
• refs/tags/v1.19.12
• refs/tags/v1.22.0
• refs/tags/v1.22.1
• refs/tags/v1.23.0
• refs/tags/v1.24.0
• refs/tags/v1.24.1
• refs/tags/v1.24.2
• refs/tags/v1.25.0
• refs/tags/v1.25.1
• refs/tags/v1.25.2
• refs/tags/v1.26.0
• refs/tags/v1.26.1
• refs/tags/v1.26.2
• refs/tags/v1.26.3
• refs/tags/v1.26.4
• refs/tags/v1.27.0
• refs/tags/v1.27.1
• refs/tags/v1.27.2
• refs/tags/v1.27.3
• refs/tags/v1.28.0
• refs/tags/v1.28.1
• refs/tags/v1.28.2
• refs/tags/v1.29.0
• refs/tags/v1.29.1
• refs/tags/v1.29.2
• refs/tags/v1.30.0
• refs/tags/v1.30.1
• refs/tags/v1.30.2
• refs/tags/v1.31.0
• refs/tags/v1.31.1
• refs/tags/v1.31.2
• refs/tags/v1.32.0
• refs/tags/v1.32.1
• refs/tags/v1.32.2
• refs/tags/v1.32.3
• refs/tags/v1.33.0
• refs/tags/v1.33.1
• refs/tags/v1.33.2
• refs/tags/v1.34.0
• refs/tags/v1.34.1
• refs/tags/v1.34.2
• release-1.19
• release-1.22
• release-1.23
• release-1.24
• release-1.25
• release-1.26
• release-1.27
• release-1.28
• release-1.29
• release-1.30
• release-1.31
• release-1.32
• release-1.32.3
• release-1.33
• release-1.33.2
• release-1.34
• release-1.35.0
• remove-duplicate-section
• test
• update-tags-examples
• yutpeng/extract-secondary-vnic
• yutpeng/secondar-vnic
• yutpeng/secondar-vnic-support

Build # 24521951809

Build Type

Pull #524

github

Committed by HadrienPatte

Commit Message

External-ccm: Use appropriate method for printf-style log calls

zap's sugared logger `Fatal`/`Error`/`Info`/`Debug` methods treat their
first argument as a plain string, not a format string. Passing format
verbs like `%s`/`%v` without the 'f' suffix causes them to appear
literally in log output instead of being interpolated.

Example of a log with no printf formatting we can see today:
```
2026-03-06T21:08:01.983Z        FATAL   FSS     csi-controller-driver/oci-csi-controller-driver.go:56 Failed to run the CSI driver for %s.FSS {"component": "csi-controller", "error": "failed to remove unix domain socket file /var/run/shared-tmpfs/csi-fss.sock"}
```

Also removed a duplicated error from a log in `node_info_controller.go`
where `err` was attached to the log both with `zap.Error(err)` and
through a (broken) printf-style `%v`.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

Pull Request Pull Request #524: External-ccm: Use appropriate method for printf-style log calls

Coverage Stats

3 of 8 new or added lines in 6 files covered. (37.5%)

6386 of 18007 relevant lines covered (35.46%)

6.64 hits per line