oracle / oci-cloud-controller-manager / 24521951809

35%

master: 36%

Pull #524

github

External-ccm: Use appropriate method for printf-style log calls

zap's sugared logger `Fatal`/`Error`/`Info`/`Debug` methods treat their
first argument as a plain string, not a format string. Passing format
verbs like `%s`/`%v` without the 'f' suffix causes them to appear
literally in log output instead of being interpolated.

Example of a log with no printf formatting we can see today:
```
2026-03-06T21:08:01.983Z        FATAL   FSS     csi-controller-driver/oci-csi-controller-driver.go:56 Failed to run the CSI driver for %s.FSS {"component": "csi-controller", "error": "failed to remove unix domain socket file /var/run/shared-tmpfs/csi-fss.sock"}
```

Also removed a duplicated error from a log in `node_info_controller.go`
where `err` was attached to the log both with `zap.Error(err)` and
through a (broken) printf-style `%v`.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

3 of 8 new or added lines in 6 files covered. (37.5%)

6386 of 18007 relevant lines covered (35.46%)

6.64 hits per line