openwisp / openwisp-radius

97%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 1.0
• 1.1
• 1.2
• Issues/550-failure-on-importing-utf-16-files
• MaxQuotaReached-override-configured-replies
• Selenium-tests-for-Dependabot-PRs-537
• allow-empty-octets
• api-change
• authorize-mac-session-check
• backport-fixes-1.2
• backport/708-to-1.2-1776952407
• backport/710-to-1.2-1777147642
• bump-version
• changelog-bot-change-bang
• chore/port-changelog-1.1.2
• chore/port-changelog-1.2.1
• chores/add-ci-failure-bot-caller
• chores/improve-ci-failure-bot
• ci/changelog_bot
• claude/bug-fix-convert-called-station-id
• cleanup_stale_radacct_hours
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.3
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.4
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.14.0
• dependabot/pip/cssselect-approx-eq-1.3.0
• dependabot/pip/cssselect-approx-eq-1.4.0
• dependabot/pip/dj-rest-auth-gte-6.0-and-lt-7.1
• dependabot/pip/dj-rest-auth-gte-6.0-and-lt-7.2
• dependabot/pip/dj-rest-auth-gte-6.0-and-lt-7.3
• dependabot/pip/django-cors-headers-gte-4.9.0
• dependabot/pip/django-ipware-gte-5.0-and-lt-7.1
• dependabot/pip/django-redis-approx-eq-6.0.0
• dependabot/pip/djangosaml2-1.10.1
• dependabot/pip/djangosaml2-1.11.1
• dependabot/pip/djangosaml2-1.12.0
• dependabot/pip/freezegun-approx-eq-1.5.2
• dependabot/pip/freezegun-approx-eq-1.5.4
• dependabot/pip/freezegun-approx-eq-1.5.5
• dependabot/pip/jsonfield-gte-3.1-and-lt-3.3
• dependabot/pip/lxml-approx-eq-5.3.1
• dependabot/pip/lxml-approx-eq-5.4.0
• dependabot/pip/lxml-approx-eq-6.0.0
• dependabot/pip/lxml-approx-eq-6.0.1
• dependabot/pip/lxml-approx-eq-6.0.2
• dependabot/pip/lxml-approx-eq-6.1.0
• dependabot/pip/pydyf-gte-0.10-and-lt-0.12
• dependabot/pip/weasyprint-gte-59-and-lt-66
• dependabot/pip/weasyprint-gte-65-and-lt-67
• dependabot/pip/weasyprint-gte-65-and-lt-68
• dependabot/pip/weasyprint-gte-65-and-lt-69
• django-allauth-65.12.0
• docs/websocket-api
• drop-python-3.9
• feat/batch-creation-async
• feature/backport-workflow
• filter-registered-users
• fix
• fix-accounting-on
• fix-admin
• fix-allowed-hosts-cidr
• fix-authorize-view
• fix-ci-djangosaml2
• fix-duplicate-urls
• fix-monitoring-integration
• fix-perform_change_of_authorization
• fix-social-account
• fix/467-postauthview-validation
• fix/crash-radiusgroup-inlines-creation
• format-by-prettier
• improve-db
• issues/510-fix-sms-message-translation
• issues/551
• issues/581-django-5
• issues/600-replace-jsonfield-clean
• issues/609-batch-user-org-field-readonly
• issues/611-fix-timezone-handling-tests
• issues/615-simultaneous-use
• issues/617-handle-stale-sessions-accounting-on
• issues/624-sanitize-called-station-id-mac-address
• issues/634-counters-return-multiple-values
• issues/643-coa
• issues/661-use-theme-color-variables
• issues/662-radius_sessions_issue
• issues/676-api-radius-user-group
• issues/677-coverage-increase-with-parallel
• issues/677-issue-increase-test-coverage
• issues/692-different-identity-verification
• issues/706-user-expiration
• issues/722-jsonfield-migration
• master
• qa
• qa-formatting
• radius-batch-base-url
• refactor-monthly_subscription
• release-1.1.1
• release/1.1.2
• release/1.2.0
• release/1.2.1
• release/1.2.2
• remove-old-django-freeradius
• replicate-version-branch
• switch-to-prettier
• tidy-up
• weasyprint

Build # 26543937000

Build Type

push

github

Committed by web-flow

Commit Message

[chores:fix] Prevented dangling relations from breaking radius migrations

Historical databases can contain dangling relations in RegisteredUser
and OrganizationUser rows. The RegisteredUser UUID and multitenant
migration helpers assumed these foreign keys were always valid and
could fail during upgrades when copying or backfilling data.

This bug was observed as a foreign key violation while inserting rows
into openwisp_radius_registereduser during the 0045/0046 migration
chain because a copied RegisteredUser.user_id no longer existed in
openwisp_users_user. The same class of issue could also affect
OrganizationUser-based backfills when a membership pointed to a missing
user or organization.

This change filters invalid RegisteredUser and OrganizationUser rows
before reusing their foreign keys in migration helpers, preserving the
existing behavior for valid data while safely skipping broken legacy
references. Focused regression tests were added to cover dangling
RegisteredUser.user_id, dangling OrganizationUser.user_id and dangling
OrganizationUser.organization_id cases.

Coverage Stats

4342 of 4457 relevant lines covered (97.42%)

10.71 hits per line