numtide / treefmt

41%

main: 39%

LAST BUILD ON BRANCH git-walker-parallel

branch: git-walker-parallel

CHANGE BRANCH

x

Reset

• git-walker-parallel
• adjust-matrix-link
• better-error
• charmbracelet-log-v2
• check-for-errors
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/cachix/install-nix-action-31
• dependabot/pip/test/examples/python/flask-3.1.3
• document-missing-formatter
• dot-config
• feat/batch-size
• feat/config-wrappers
• feat/git-merge-tool
• feat/git-untracked-files
• feat/go-1.24
• feat/refine-docs
• feat/refine-error-handling
• feat/refine-untracked-files
• feat/refine-vendor-hash-update
• feat/simpler-nix-build
• feat/tree-root-cmd
• feat/update-vendor-hash-automatically
• feat/validate-formatter-name
• feat/verbosity-changes
• fix-renovate-config
• fix/cachix-install-nix-action
• fix/completions
• fix/concurrent-invocation
• fix/context-cancellation
• fix/default-tree-root-cmd
• fix/exit-on-formatter-errors
• fix/logging
• fix/non-ascii-paths
• fix/stdin-exlude-behaviour
• fix/update-vendor-hash-workflow
• fixup/non-ascii-paths
• main
• mergify/configuration-deprecated-update
• more-linter
• new-README
• refine-renovate-config
• renovate/actions-checkout-5.x
• renovate/actions-checkout-6.x
• renovate/actions-setup-go-6.x
• renovate/github.com-otiai10-copy-1.x
• renovate/github.com-spf13-cobra-1.x
• renovate/github.com-spf13-pflag-1.x
• renovate/github.com-stretchr-testify-1.x
• renovate/go-1.x
• renovate/golang.org-x-sync-0.x
• renovate/golang.org-x-sys-0.x
• renovate/goreleaser-goreleaser-action-7.x
• renovate/ubuntu-24.x
• tagline
• termenv-fix
• update-cache-url
• updates
• v2.1.1
• v2.2.0
• v2.2.1
• v2.3.0
• v2.3.1
• v2.3.2
• v2.4.0
• v2.4.2
• v2.5.0

Build # 25289868151

Build Type

Pull #694

github

Committed by Mic92

Commit Message

walk: unblock producers when Close() is called before EOF

When the format loop exits early (Ctrl+C, or `on-unmatched = fatal`),
walker.Close() is called while producers are still blocked on send --
git/jj on a full 64 KB stdout pipe (~1.6k paths), the filesystem walker
on a full filesCh -- so errgroup.Wait() hangs until kill -9.

Have Close() fire a cancellation signal first: a context for the git/jj
readers (also kills the child via exec.CommandContext) and a done
channel that filepath.Walk selects against. Regression tests overflow
the buffer and assert Close() returns without Read() being called.

Pull Request Pull Request #694: walk/git: split ls-files and stat paths concurrently

Coverage Stats

143 of 178 new or added lines in 3 files covered. (80.34%)

1 existing line in 1 file now uncovered.

878 of 2117 relevant lines covered (41.47%)

17.21 hits per line