numtide / treefmt / 25289868151

41%

main: 40%

Build Type

Pull #694

github

Committed by Mic92

Commit Message

walk: unblock producers when Close() is called before EOF

When the format loop exits early (Ctrl+C, or `on-unmatched = fatal`),
walker.Close() is called while producers are still blocked on send --
git/jj on a full 64 KB stdout pipe (~1.6k paths), the filesystem walker
on a full filesCh -- so errgroup.Wait() hangs until kill -9.

Have Close() fire a cancellation signal first: a context for the git/jj
readers (also kills the child via exec.CommandContext) and a done
channel that filepath.Walk selects against. Regression tests overflow
the buffer and assert Close() returns without Read() being called.

Pull Request Pull Request #694: walk/git: split ls-files and stat paths concurrently

Coverage Stats

143 of 178 new or added lines in 3 files covered. (80.34%)

1 existing line in 1 file now uncovered.

878 of 2117 relevant lines covered (41.47%)

17.21 hits per line