nextras / orm
92%
master: 92%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 141
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 91.945%. Remained the same
32193606707

push

github

web-flow 
add #[\NoDiscard] to read-only API (#827)

* add #[\NoDiscard] to read-only API

Marks the methods that only compute and return a value with PHP 8.5's
#[\NoDiscard] attribute, so that PHP reports ignoring their return value.
Most notably the whole ICollection API, where discarding the result of
findBy()/orderBy()/limitBy() silently does nothing, as the collection is
immutable; those methods carry an explanatory message. Also covers
IRepository, IModel, IRepositoryLoader, IMapper, IEntity and the
relationship getters.

The attribute is not inherited by overriding methods, so it is declared
both on the interfaces (as documentation) and on their implementations
(where it is actually evaluated). Methods called for their side effect
are left out, incl. ICollection::setRelationshipMapper() which mutates
the collection in place.

On PHP 8.1-8.4 the attribute has no effect.

Closes #805

* tests: use the return values of #[\NoDiscard] methods

PHPStan reports method.resultDiscarded (non-ignorable) for calls whose
return value is thrown away on a separate line. The (void) cast is not
an option here, as the codebase supports PHP 8.1+, so the values are
assigned instead - incl. Repository::doRefreshAll(), where the fetch is
done for its identity-map side effect.

---------

Co-authored-by: Claude <noreply@anthropic.com>

4 of 4 new or added lines in 2 files covered. (100.0%)

4349 of 4730 relevant lines covered (91.95%)

5.39 hits per line

Relevant lines Covered
4730 RELEVANT LINES 4349 COVERED LINES
5.39 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32193606707 main add #[\NoDiscard] to read-only API (#827) * add #[\NoDiscard] to read-only API Marks the methods that only compute and return a value with PHP 8.5's #[\NoDiscard] attribute, so that PHP reports ignoring their return value. Most notably the whole... push web-flow github
91.95
32192935264 claude/nextras-orm-805-pr-oml4a7 Merge 0880e7f45 into aea7d1832 Pull #827 web-flow github
91.95
32191453527 js/major-issues-fixes Merge f87c563b2 into aea7d1832 Pull #826 web-flow github
92.0
31559587029 renovate/mysql-26.x Merge 0884ba877 into aea7d1832 Pull #824 web-flow github
91.95
31489117560 main chore(deps): update dependency phpstan/phpstan to v2.2.8 (#825) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> push web-flow github
91.95
30958568317 renovate/phpstan-packages Merge dd8e3377e into 21fc807bf Pull #825 web-flow github
91.95
30558754693 renovate/mysql-26.x Merge bf5830cb4 into 21fc807bf Pull #824 web-flow github
91.95
30522788280 main chore(deps): update phpstan packages (#823) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> push web-flow github
91.95
30482948230 renovate/phpstan-packages Merge e8e21db6a into 7b0dbc906 Pull #823 web-flow github
91.95
30287043438 renovate/phpstan-packages Merge 7202dcbbc into 7b0dbc906 Pull #823 web-flow github
91.95
See All Builds (2061)