nette / latte

95%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 3.1.4
• dedent-preserve-structural-indentation
• master
• next
• v2.10
• v2.10.10
• v2.11
• v2.11.7
• v2.5
• v2.6
• v2.7
• v2.8
• v2.9
• v3.0
• v3.0.10
• v3.0.11
• v3.0.11-RC1
• v3.0.12
• v3.0.13
• v3.0.14
• v3.0.15
• v3.0.16
• v3.0.17
• v3.0.18
• v3.0.19
• v3.0.20
• v3.0.21
• v3.0.22
• v3.0.23
• v3.0.24
• v3.0.25
• v3.0.9
• v3.1.0
• v3.1.1
• v3.1.2
• v3.1.3
• v3.1.4
• v3.1.5
• v3.1.6
• wip

Build # 30653514805

Build Type

push

github

Committed by dg

Commit Message

HtmlHelpers: contenteditable, draggable, spellcheck & hidden are not boolean attributes (BC break)

None of them is a boolean attribute in HTML; they are enumerated ones, so
rendering them as a bare name was wrong in three separate ways:

- a string 'false' is truthy in PHP, so contenteditable={$s} rendered the
  attribute present, i.e. the exact opposite of what was asked for
- the empty value is not a keyword of draggable, it maps to the invalid value
  default 'auto', so draggable=true could not be expressed at all
- 'attribute missing' and 'attribute false' are different states; the false
  value is what disables editing inside a contenteditable region, and dropping
  the attribute silently inherited from the parent instead

Two new categories replace them. 'tristate' (contenteditable, draggable,
spellcheck, writingsuggestions) maps bool to the true/false keywords, exactly
like aria-* already does, so formatAriaAttribute now delegates to it. The
'valuedBool' one (hidden, popover) stays a flag but keeps a non-empty value,
so hidden="until-found" survives. Falsy values are tested first there: hidden
with a '0' coming from a database must not render hidden="0", which is an
invalid value and would map back to the hidden state.

Coverage Stats

15 of 15 new or added lines in 2 files covered. (100.0%)

6073 of 6397 relevant lines covered (94.94%)

0.95 hits per line