nestjs / nest
89%
master: 89%

LAST BUILD BRANCH: feat/devcontainer-support
DEFAULT BRANCH: master
Repo Added
Files 356
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/http-exceptions-default-description-v2
branch: fix/http-exceptions-default-description-v2
CHANGE BRANCH
x

coverage: 88.939%. Remained the same
8a135727-6ce0-4aba-a7ae-912360797e37

Pull #16017

circleci

evgeniy.chernomortsev 
fix(common): preserve default description for all HTTP exceptions when using options

When passing an options object with `cause` to built-in HTTP exceptions,
the default description was lost because `extractDescriptionAndOptionsFrom`
returns `undefined` for the description property when options object is passed.

Fixed by adding destructuring default values for the description in each
exception constructor, matching the default value from the parameter.

For example:
```typescript
// Before: description would be undefined
const { description, httpExceptionOptions } = ...

// After: description defaults to 'Bad Request' if undefined
const { description = 'Bad Request', httpExceptionOptions } = ...
```

Applied fix to all 21 built-in HTTP exceptions:
- BadGatewayException
- BadRequestException
- ConflictException
- ForbiddenException
- GatewayTimeoutException
- GoneException
- HttpVersionNotSupportedException
- ImATeapotException
- InternalServerErrorException
- MethodNotAllowedException
- MisdirectedException
- NotAcceptableException
- NotFoundException
- NotImplementedException
- PayloadTooLargeException
- PreconditionFailedException
- RequestTimeoutException
- ServiceUnavailableException
- UnauthorizedException
- UnprocessableEntityException
- UnsupportedMediaTypeException

Closes #15961
Pull Request #16017: fix(common): preserve default description for all HTTP exceptions when using options

2773 of 3498 branches covered (79.27%)

7325 of 8236 relevant lines covered (88.94%)

17.68 hits per line

Relevant lines Covered
8236 RELEVANT LINES 7325 COVERED LINES
17.68 HITS PER LINE
Source Files on fix/http-exceptions-default-description-v2

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
8a135727... fix/http-exceptions-default-description-v2 fix(common): preserve default description for all HTTP exceptions when using options When passing an options object with `cause` to built-in HTTP exceptions, the default description was lost because `extractDescriptionAndOptionsFrom` returns `und... Pull #16017 evgeniy.chernomortsev circleci
88.94
See All Builds (26876)