nestjs / nest / 8a135727-6ce0-4aba-a7ae-912360797e37

89%

master: 90%

Build Type

Pull #16017

circleci

Committed by evgeniy.chernomortsev

Commit Message

fix(common): preserve default description for all HTTP exceptions when using options

When passing an options object with `cause` to built-in HTTP exceptions,
the default description was lost because `extractDescriptionAndOptionsFrom`
returns `undefined` for the description property when options object is passed.

Fixed by adding destructuring default values for the description in each
exception constructor, matching the default value from the parameter.

For example:
```typescript
// Before: description would be undefined
const { description, httpExceptionOptions } = ...

// After: description defaults to 'Bad Request' if undefined
const { description = 'Bad Request', httpExceptionOptions } = ...
```

Applied fix to all 21 built-in HTTP exceptions:
- BadGatewayException
- BadRequestException
- ConflictException
- ForbiddenException
- GatewayTimeoutException
- GoneException
- HttpVersionNotSupportedException
- ImATeapotException
- InternalServerErrorException
- MethodNotAllowedException
- MisdirectedException
- NotAcceptableException
- NotFoundException
- NotImplementedException
- PayloadTooLargeException
- PreconditionFailedException
- RequestTimeoutException
- ServiceUnavailableException
- UnauthorizedException
- UnprocessableEntityException
- UnsupportedMediaTypeException

Closes #15961

Pull Request Pull Request #16017: fix(common): preserve default description for all HTTP exceptions when using options

Run Details

2773 of 3498 branches covered (79.27%)

7325 of 8236 relevant lines covered (88.94%)

17.68 hits per line