neithere / argh

93%

Build Type

Pull #134

travis-ci

Committed by web-flow

Commit Message

Fix bug with skip_unknown_args=True

Passing `skip_unknown_args=True` to the parser only ever showed the
usage message.

The problem is that `parser.parse_known_args()`
(`ArgumentParser.parse_known_args`) returns a tuple
`(namespace, remainder)` instead of just a namespace object like
`parser.parse_args`. Once you pass this to
`_get_function_from_namespace_obj` it gets confused.

The unit test was expecting to only ever show the usage message when
skipping unknown args.

The remaining unknown args are stored on the namespace as `_unkown_args`,
so it's at least accessible (if we use `@expects_obj`)

```python
import argh
parser = argh.ArghParser()

@argh.arg('a')
@argh.expects_obj
def foo(args):
    print 'foo args', args

parser.add_commands([foo, bar])
parser.dispatch(skip_unknown_args=True)
```

Pull Request Pull Request #134: Fix bug with skip_unknown_args=True

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

461 of 495 relevant lines covered (93.13%)

3.57 hits per line