nats-io / node-nats-streaming

91%

master: 94%

LAST BUILD ON BRANCH ping-doc

branch: ping-doc

CHANGE BRANCH

x

Reset

• ping-doc
• 0.0.3
• 0.0.4
• ack-fix-15
• ackInbox-safety
• cncf
• coded-errors
• defer-subs-until-protocol
• dep-updates-release
• dev-deps-update
• doc
• duplicate-clientid-must-fail
• error-on-throw
• es6-lint
• fix-64
• fix-82
• fix-92
• fix-97-98
• fix-97-98-99
• fix-coveralls
• fix71
• master
• node-version-constraint
• node-version-fix
• node10-deprecations
• non-wip
• port-option-fix
• protobuf-fix
• qlik-trial-client-side-pings
• reconnect-gives-nats-not-streaming-connection
• rename-publishasync-to-publish
• soulne4ny-master
• stan-nodejs-compat
• stan-ts-bindings
• sub-close
• subopts-time-fixes-17
• subscription-options-fixes
• typescript
• update-copyright
• update-to-reqone
• v.0.0.14
• v.0.0.50
• v0.0.28
• v0.0.40
• v0.0.51
• v0.0.52
• v0.0.8
• v0.1.0
• v0.2.0
• v0.2.2

Build # 234

Build Type

Pull #96

travis-ci

Committed by web-flow

Commit Message

- added (copied shamelessly) documentation from go-nats-streaming describing
how the client ping mechanism works.
- filled connection id in PubMsg
- added test to verify that PubMsg contains connection id and client id

Changed node-nats-streaming default for `maxReconnectAttempts` to be
infinite on connections created by the stan client (matching the
behaviour of the go-nats-streaming client)

Fixed tests that relied on `maxReconnectAttempts`.

Pull Request Pull Request #96: Ping documentation and default value for maxReconnectAttempts

Run Details

142 of 193 branches covered (73.58%)

6 of 6 new or added lines in 1 file covered. (100.0%)

425 of 469 relevant lines covered (90.62%)

29.4 hits per line