nats-io / jwt

81%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 2_4_0
• add-issue-forms
• add_in_process_conn_type
• add_msg_trace_support
• add_require_proxied_user_perm
• any-account
• auth_users_omitempty
• authorization_omitempty
• branch_v1
• bump-nkeys
• bumps
• case-sensitive-tags
• cluster-traffic
• cluster-traffic-as-string
• complex-tags
• convenience-tags
• dependabot/go_modules/v2/golang.org/x/crypto-0.17.0
• dependabot/go_modules/v2/golang.org/x/crypto-0.31.0
• did-sign
• equals-fold
• example
• feat/import-same-service-from-diff-accounts
• fix-badge
• fix-crypto-cve
• fix-issue-config-discussions-link
• fix-nsc-657
• fix-nsc-775
• gh-ci
• harden-cred-generation
• main
• msg_trace_sampling
• neil/accountnrg
• operator-ws
• pdp/fossa
• pdp/v2-v1-detangle
• pdp/version-2.4.0
• ppc64
• refs/tags/v2.4.0
• refs/tags/v2.4.1
• refs/tags/v2.5.0
• refs/tags/v2.5.1
• refs/tags/v2.5.2
• refs/tags/v2.5.3
• refs/tags/v2.5.4
• refs/tags/v2.5.5
• refs/tags/v2.5.6
• refs/tags/v2.5.7
• refs/tags/v2.5.8
• refs/tags/v2.6.0
• refs/tags/v2.7.0
• refs/tags/v2.7.1
• refs/tags/v2.7.2
• refs/tags/v2.7.3
• refs/tags/v2.7.4
• refs/tags/v2.8.0
• retract-set
• retract-tags
• retract2
• rm-tag-error
• role-description
• sharing
• sign-fn
• simplify-response
• simplify-response-go-mod
• sk_sort
• tags
• unsquat-iana
• update-deps

Build # 22505453099

Build Type

push

github

Committed by web-flow

Commit Message

fix: allow import of same service subject from different accounts (#243)

nats-server already allows importing the same (service) subject from different account, while the jwt does not. This becomes an issue when you, for instance, source JetStreams from different accounts and need to import service `$JS.FC.>` from both. Before, this could be solved by importing e.g. `$JS.FC.STREAM_FROM_ACC_X.>` and `$JS.FC.STREAM_FROM_ACC_Y.>`, but this requires globally unique stream names. If those streams are both called `ORDERS` then you wouldn't be able to source both.

Issue: https://github.com/nats-io/nats-server/issues/7326
Related: https://github.com/nats-io/nats-server/pull/6704
Related: https://github.com/nats-io/nats-server/issues/6547
Related: https://github.com/nats-io/nats-server/issues/6431

Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

2773 of 3417 relevant lines covered (81.15%)

27.02 hits per line