nagayon-935 / mping

85%

main: 83%

LAST BUILD ON BRANCH refactor/code-cleanup

branch: refactor/code-cleanup

CHANGE BRANCH

x

Reset

• refactor/code-cleanup
• add_copilot_reviewer
• add_function_port_check
• docs/readme-english
• feature/configurable-thresholds
• feature/json-export-and-yaml-watch
• feature/linux-support
• feature/mtr-monitor
• feature/pmtu-hop-detection
• feature/port-monitor-improvements
• feature/traceroute-hops-initttl
• file_option
• fix-ui-layout-duplication
• fix/go-review-issues
• fix/stability-issues
• fix/ui-rendering-issues
• main
• refactor/go-review-fixes
• refactor/hardcoded-constants
• refactor/improvements

Build # 23676295051

Build Type

Pull #8

github

Committed by nagayon-935

Commit Message

refactor: reduce duplication and improve code structure without changing behavior

- icmp_errors.go: replace switch statements with map-based lookups, extract icmpErrorBodyData helper
- pinger.go: unify runReceiverV4/V6 into shared runReceiver loop with handleEchoReply/handleICMPError,
  split runWorker into resolveTarget/getWriteFunc/sendProbe/waitForReply sub-functions
- tui.go: extract duplicated double-border drawing into makeDoubleBorderDrawFunc,
  move traceroute/port-monitor rendering into renderTracerouteTable/renderPortMonitorTable,
  remove unused tablePaneHeight constant (Run() reduced from ~884 to ~470 lines)
- tui_helpers.go: add paddedCell, statusColorTag shared helpers
- Add tests for all newly extracted functions in both pinger and ui packages

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pull Request Pull Request #8: refactor: reduce duplication and improve code structure without chang…

Coverage Stats

402 of 449 new or added lines in 4 files covered. (89.53%)

2 existing lines in 1 file now uncovered.

2543 of 2976 relevant lines covered (85.45%)

1.0 hits per line