nagayon-935 / mping

88%

main: 83%

LAST BUILD ON BRANCH fix/stability-issues

branch: fix/stability-issues

CHANGE BRANCH

x

Reset

• fix/stability-issues
• add_copilot_reviewer
• add_function_port_check
• docs/readme-english
• feature/configurable-thresholds
• feature/json-export-and-yaml-watch
• feature/linux-support
• feature/mtr-monitor
• feature/pmtu-hop-detection
• feature/port-monitor-improvements
• feature/traceroute-hops-initttl
• file_option
• fix-ui-layout-duplication
• fix/go-review-issues
• fix/ui-rendering-issues
• main
• refactor/code-cleanup
• refactor/go-review-fixes
• refactor/hardcoded-constants
• refactor/improvements

Build # 24299198320

Build Type

Pull #15

github

Committed by nagayon-935

Commit Message

fix: address go-reviewer findings from stability fixes

- Simplify Close() to delegate to Stop() instead of duplicating the
  channel-close guard (pinger.go)
- Eliminate data race in Start(): store results slice inside PortChecker
  so Start() never reads t.PortResults directly (portchecker.go)
- Handle header write error in setupLogger; return error instead of
  silently dropping it (mping.go)
- Unify ipv4/ipv6 conflict error message between mergeHosts and parseArgs
  (mping.go)
- Add regression tests: setupLogger with existing file must not duplicate
  header; mergeHosts must reject ipv4+ipv6 in YAML (mping_test.go)

Pull Request Pull Request #15: Fix/stability issues

Coverage Stats

19 of 34 new or added lines in 5 files covered. (55.88%)

2717 of 3074 relevant lines covered (88.39%)

1.04 hits per line