mysociety / pombola

55%

master: 60%

LAST BUILD ON BRANCH unify-disqus-threads

branch: unify-disqus-threads

CHANGE BRANCH

x

Reset

• unify-disqus-threads
• 2214-ncop-too-on-mp-profiles
• 2222-sa-hide-positions-and-places
• 2233-za-remove-search-dropdown
• 2250-za-homepage-button-experiment
• 2251-minister-profile-atttendance-numbers
• 2256-2016-members-interests
• 2262-mzalendo-dokeza
• 2263-mzalendo-election-sms-code
• 2268-cta-component-for-static-pages
• 2268-text-chage
• 2271-new-attendance-api
• 2281-always-output-facebook-app-id
• 2281-comments-not-working
• 2290-ke-homepage-ynr-link
• 2303-mzalendo-homepage-slider
• 2303-mzalendo-homepage-update
• 2304-ke-responsibilities
• 2314-young-rep-and-women-pages
• 2330-add-everypolitician-uuid-to-person
• 2348-survey-admin-section
• 2348-survey-admin-section-update-homepage
• 2353-messages-not-loading-when-linked-directly
• 2365-add-writeinpublic-configuration-model
• 2365-update-views-to-use-configuration-values
• 2391-fix-person-adapter-name-error
• 2393-home-actions-lined-up
• 2399-fix-500-on-non-contactable-committees
• 2402-fix-error-when-committees-have-multiple-emails
• 2407-za-writeinpublic-blurbs
• 2408-group-mp-speech-counts-by-year
• 2415-za-homepage-find-rep-confusion
• 2420-ke-filter-hansard-search-by-person
• 2421-ke-homepage-redesign
• 2423-grid-layout-for-keyna-reps
• 2433-za-remove-blog-nav-submenu
• 2445-improve-members-interests-page
• 2447-mzalendo-nav-updates
• 2454-update-mzalendo-mission
• 2462-cronjob-to-pull-in-sms-messages
• 2462-question-model
• 2462-retrieve-sms-messages
• 2473-kenya-hansard-constituency-party-name-matching
• 2475-za-simplify-province-pages
• 2477-za-parliament-list-page
• 2486-za-parliament-search
• 2491-ke-accessibility-improvements
• 2496-allow-places-to-have-images
• 2497-ke-opengraph-tags
• 2501-fix-alias-admin-error
• 2502-update-kenya-hansard-scraper
• 2504-shujaaz-2019
• 2505-separate-unmatched-people-command
• 2527-change-membership-text-on-province-page
• 2528-fix-constituency-office-people-display
• 2528-no-related-people-for-constituency-offices
• 2548-ward-councillor-ordering-bug
• 2555-fix-multiple-active-tabs-on-rep-locator
• 2556-static-mp-count
• 2557-change-committee-navigation-text
• 2567-update-to-new-sms-api
• 2569-remove-shujaaz-2018-banner
• 2574-fix-parsererror-from-lxml
• 2589-writeinpublic-500-error
• 27th-parliament
• New-survey-for-ZA
• activate-writeinpublic-integration
• add-2017-photos-from-ynr
• add-commonlib-to-crontab-path
• add-coverage-report
• add-page-listing-all-committees
• add-person-everypolitician_uuid-method
• add-surveys-to-database-dump-command
• always-export-person-slug
• change-featured-mp-show-more-link
• change-survey-link
• check-hidden-field-when-merging
• civil-unions-survey
• closing-land-issue-survey
• codeclimate
• committee-popolo-json-endpoint
• country-specific-vagrant
• dependabot/pip/coverage-4.5.2
• dependabot/pip/coverage-4.5.3
• dependabot/pip/coverage-4.5.4
• dependabot/pip/dj-database-url-0.5.0
• dependabot/pip/django-extensions-2.1.4
• dependabot/pip/django-extensions-2.1.5
• dependabot/pip/django-extensions-2.1.6
• dependabot/pip/django-extensions-2.1.7
• dependabot/pip/django-extensions-2.1.9
• dependabot/pip/django-registration-defaults-0.4.4
• dependabot/pip/django-social-auth-0.7.28
• dependabot/pip/gunicorn-19.9.0
• dependabot/pip/lxml-4.3.4
• dependabot/pip/markdown-3.0.1
• dependabot/pip/markdown-3.1
• dependabot/pip/markdown-3.1.1
• dependabot/pip/pillow-5.3.0
• dependabot/pip/pillow-5.4.0
• dependabot/pip/pillow-5.4.1
• dependabot/pip/pillow-6.0.0
• dependabot/pip/python-memcached-1.59
• dependabot/pip/pyyaml-5.1
• dependabot/pip/requests-2.20.0
• dependabot/pip/urllib3-1.23
• dependabot/pip/urllib3-1.24.1
• dependabot/pip/urllib3-1.24.2
• dependabot/pip/waitress-1.3.0
• dependabot/pip/webob-1.8.4
• dependabot/pip/webob-1.8.5
• disable-template-cache-on-staging
• display-original-speaker-names
• edit-mp-attendance-message
• fix-500-error-on-elections-pages
• fix-tests
• fix-travis-build
• fix-zero-results-error
• google-maps-api-key
• hack-kenya_hansard_speech_statistics-to-display-all-problems
• handle-sms-tables-in-db-dump
• hansard-name-matching-fixes
• hansard-nominated-reps-fix
• ignore-ruby-version-file
• improve-template-settings
• issues/2249-za-fuzzy-search
• issues/2259-mp-search-event-reporting
• issues/2267-menu-rearrangement
• issues/2274-homepage-3-way-test
• issues/2279-add-social-media-links-to-mzalendo-home
• issues/2289-add-attendence-redirect
• issues/2293-make-ab-result-permanent
• issues/2302-mzalendo-menu-changes
• issues/2360-za-richer-identifiers
• issues/2404-preferred-email
• issues/2406-alphabetical-committee-sort
• issues/2429-shorter-committee-names
• issues/2446-survey-link
• ke-import-2017-winners
• landsurvey-readmore
• make-person-uuid-prefix-configurable
• make-writeinpublic-views-more-generic
• master
• new-javascript-rss-feed
• openup-survey-land
• pg-dump-on-remote-server
• pombola-background-doc
• provincial-candidates-2019
• public-healthcare-survey
• redirect-to-thanks-page-after-sending-message
• remove-contributing-md
• remove-old-design-todo-file
• remove-old-docs
• remove-people-link-from-menu
• remove-pymongo-dependency
• remove-syncdb-from-prepare_environment
• remove-unused-code
• remove-unused-files
• remove-whitenoise
• remove-writeinpublic-config
• revert-current-version
• revert-json-gem-upgrade
• scrutinizer-coverage
• send-messages-via-writeinpublic
• sessions-for-south-africa
• south-africa-2019-election-candidates
• south-africa-election-results-2019
• split-kenya
• survey-link-change
• sync-everypolitician-uuid-cron-job
• template-for-blog-endpoint
• travis-ci-fixes
• turn-nigeria-export-cron-on
• update-browser-statistics
• update-clean-disqus-command
• update-db-dump-ignored-tables
• update-readme-with-test-guidance
• update-za-hansard-version
• update-za-hansard-with-decoding-fix
• upgrade-django-sayit
• use-google-maps-geocoding-api-key
• use-url-namespaces-in-writeinpublic-app
• vagrant-stretch
• various-hansard-name-matching-fixes-and-enhancements
• write-to-committees
• writeinpublic-api-client
• writeinpublic-django-app
• writeinpublic-homepages-changes
• writeinpublic-styling
• writeinpublic-views
• za-add-email-address-class
• za-correct-tab-on-pageload
• za-csv-output
• za-feedback-tweaks-feb-2018
• za-import-wikidata-ids-from-ep
• za-make-featured-mp-configurable
• za-make-home-buttons-bigger
• zero-vat-survey

Build # 4098

Build Type

Pull #2469

travis-ci

Committed by web-flow

Commit Message

Switch Disqus JS to use the same URL for all pages relating to a Person

Previously there were separate threads on the sub-pages (e.g.
/person/uhuru-kenyatta/contact_details/) from the main page for a person
(e.g. /person/uhuru-kenyatta/). The same applied for places,
organizations, and the peron-specific hansard pages.

This updates the Disqus JavaScript to use the disqus_canonical_url and
disqus_identifier variables we're now adding to the context, which
should be the same for all pages relating to a single person / place /
organization.

It also switches to the currently recommended way of setting the Disqus
JavaScript configuration variables, which is by defining a disqus_config
function which sets this.page.url, this.page.identifier and
this.page.title.

Pull Request Pull Request #2469: Unify Disqus threads for single people / places / organizations

Run Details

14 of 14 new or added lines in 3 files covered. (100.0%)

10883 of 19790 relevant lines covered (54.99%)

0.55 hits per line