mysociety / pombola

55%

master: 60%

LAST BUILD ON BRANCH 2548-ward-councillor-ordering-bug

branch: 2548-ward-councillor-ordering-bug

CHANGE BRANCH

x

Reset

• 2548-ward-councillor-ordering-bug
• add-coverage-report
• master
• display-original-speaker-names
• 2222-sa-hide-positions-and-places
• turn-nigeria-export-cron-on
• 2233-za-remove-search-dropdown
• edit-mp-attendance-message
• always-export-person-slug
• 2214-ncop-too-on-mp-profiles
• 2251-minister-profile-atttendance-numbers
• update-readme-with-test-guidance
• 2256-2016-members-interests
• improve-template-settings
• 2262-mzalendo-dokeza
• disable-template-cache-on-staging
• 2263-mzalendo-election-sms-code
• 2250-za-homepage-button-experiment
• 2271-new-attendance-api
• issues/2274-homepage-3-way-test
• 2281-comments-not-working
• issues/2279-add-social-media-links-to-mzalendo-home
• 2281-always-output-facebook-app-id
• sessions-for-south-africa
• 2290-ke-homepage-ynr-link
• issues/2293-make-ab-result-permanent
• issues/2289-add-attendence-redirect
• issues/2267-menu-rearrangement
• scrutinizer-coverage
• issues/2259-mp-search-event-reporting
• 2268-cta-component-for-static-pages
• new-javascript-rss-feed
• issues/2249-za-fuzzy-search
• 2303-mzalendo-homepage-update
• ke-import-2017-winners
• update-browser-statistics
• add-2017-photos-from-ynr
• issues/2302-mzalendo-menu-changes
• 2303-mzalendo-homepage-slider
• 2304-ke-responsibilities
• use-google-maps-geocoding-api-key
• 2268-text-chage
• pg-dump-on-remote-server
• send-messages-via-writeinpublic
• 2330-add-everypolitician-uuid-to-person
• za-correct-tab-on-pageload
• 2314-young-rep-and-women-pages
• travis-ci-fixes
• sync-everypolitician-uuid-cron-job
• add-person-everypolitician_uuid-method
• writeinpublic-django-app
• writeinpublic-api-client
• writeinpublic-views
• writeinpublic-styling
• activate-writeinpublic-integration
• writeinpublic-homepages-changes
• za-add-email-address-class
• issues/2360-za-richer-identifiers
• za-import-wikidata-ids-from-ep
• 2365-update-views-to-use-configuration-values
• 2365-add-writeinpublic-configuration-model
• za-feedback-tweaks-feb-2018
• za-make-home-buttons-bigger
• za-make-featured-mp-configurable
• change-featured-mp-show-more-link
• change-survey-link
• remove-writeinpublic-config
• redirect-to-thanks-page-after-sending-message
• write-to-committees
• committee-popolo-json-endpoint
• make-person-uuid-prefix-configurable
• use-url-namespaces-in-writeinpublic-app
• fix-zero-results-error
• make-writeinpublic-views-more-generic
• 2391-fix-person-adapter-name-error
• fix-tests
• update-db-dump-ignored-tables
• add-page-listing-all-committees
• 2399-fix-500-on-non-contactable-committees
• 2402-fix-error-when-committees-have-multiple-emails
• 2353-messages-not-loading-when-linked-directly
• survey-link-change
• update-za-hansard-version
• issues/2404-preferred-email
• New-survey-for-ZA
• 2393-home-actions-lined-up
• openup-survey-land
• 2415-za-homepage-find-rep-confusion
• closing-land-issue-survey
• landsurvey-readmore
• 2423-grid-layout-for-keyna-reps
• issues/2446-survey-link
• 2454-update-mzalendo-mission
• 2445-improve-members-interests-page
• 2407-za-writeinpublic-blurbs
• 2433-za-remove-blog-nav-submenu
• 2447-mzalendo-nav-updates
• issues/2406-alphabetical-committee-sort
• zero-vat-survey
• template-for-blog-endpoint
• issues/2429-shorter-committee-names
• unify-disqus-threads
• update-clean-disqus-command
• civil-unions-survey
• 2421-ke-homepage-redesign
• pombola-background-doc
• 2477-za-parliament-list-page
• 2462-retrieve-sms-messages
• 2462-cronjob-to-pull-in-sms-messages
• 2462-question-model
• 2486-za-parliament-search
• update-za-hansard-with-decoding-fix
• handle-sms-tables-in-db-dump
• 2475-za-simplify-province-pages
• google-maps-api-key
• public-healthcare-survey
• 2497-ke-opengraph-tags
• 2491-ke-accessibility-improvements
• 2505-separate-unmatched-people-command
• 2502-update-kenya-hansard-scraper
• 2501-fix-alias-admin-error
• za-csv-output
• 2348-survey-admin-section
• 2348-survey-admin-section-update-homepage
• dependabot/pip/urllib3-1.24.1
• dependabot/pip/django-extensions-2.1.4
• dependabot/pip/webob-1.8.4
• dependabot/pip/gunicorn-19.9.0
• dependabot/pip/pillow-5.3.0
• dependabot/pip/django-social-auth-0.7.28
• add-surveys-to-database-dump-command
• dependabot/pip/python-memcached-1.59
• dependabot/pip/markdown-3.0.1
• dependabot/pip/dj-database-url-0.5.0
• dependabot/pip/coverage-4.5.2
• dependabot/pip/django-registration-defaults-0.4.4
• 2504-shujaaz-2019
• 2528-no-related-people-for-constituency-offices
• dependabot/pip/pillow-5.4.0
• dependabot/pip/pillow-5.4.1
• 2408-group-mp-speech-counts-by-year
• 2527-change-membership-text-on-province-page
• 2496-allow-places-to-have-images
• remove-old-design-todo-file
• 2420-ke-filter-hansard-search-by-person
• dependabot/pip/django-extensions-2.1.5
• dependabot/pip/webob-1.8.5
• 2557-change-committee-navigation-text
• 2473-kenya-hansard-constituency-party-name-matching
• dependabot/pip/django-extensions-2.1.6
• remove-old-docs
• hansard-name-matching-fixes
• hansard-nominated-reps-fix
• 2569-remove-shujaaz-2018-banner
• dependabot/pip/coverage-4.5.3
• various-hansard-name-matching-fixes-and-enhancements
• hack-kenya_hansard_speech_statistics-to-display-all-problems
• 2574-fix-parsererror-from-lxml
• 2555-fix-multiple-active-tabs-on-rep-locator
• 2567-update-to-new-sms-api
• 2528-fix-constituency-office-people-display
• 2556-static-mp-count
• dependabot/pip/markdown-3.1
• dependabot/pip/pillow-6.0.0
• 2589-writeinpublic-500-error
• dependabot/pip/urllib3-1.23
• dependabot/pip/urllib3-1.24.2
• south-africa-2019-election-candidates
• dependabot/pip/django-extensions-2.1.7
• dependabot/pip/markdown-3.1.1
• provincial-candidates-2019
• fix-travis-build
• south-africa-election-results-2019
• remove-unused-code
• vagrant-stretch
• codeclimate
• 27th-parliament
• remove-people-link-from-menu
• revert-current-version
• revert-json-gem-upgrade
• country-specific-vagrant
• split-kenya
• ignore-ruby-version-file
• remove-unused-files
• add-commonlib-to-crontab-path
• fix-500-error-on-elections-pages
• check-hidden-field-when-merging
• remove-whitenoise
• dependabot/pip/django-extensions-2.1.9
• dependabot/pip/pyyaml-5.1
• dependabot/pip/waitress-1.3.0
• dependabot/pip/requests-2.20.0
• remove-syncdb-from-prepare_environment
• dependabot/pip/lxml-4.3.4
• remove-pymongo-dependency
• remove-contributing-md
• upgrade-django-sayit
• dependabot/pip/coverage-4.5.4

Build # 4359

Build Type

Pull #2549

travis-ci

Committed by web-flow

Commit Message

[ZA] Fix intermittent problem with Ward Councillor lookups

This code was making a bad assumption about the order of things in the
response from the code4sa mapit API. It was assuming that ward would
always come first, and then municipality. But it seems that was not the
case, the order of results from mapit is actually random and shouldn't
be relied on.

So this change adds some extra checks to ensure we're using the correct
bits of the JSON for the ward and municipality.

Pull Request Pull Request #2549: [ZA] Fix intermittent problem with Ward Councillor lookups

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

11036 of 20053 relevant lines covered (55.03%)

0.55 hits per line