mxschmitt / playwright-go

79%

main: 79%

Pull #625

github

fix: guard pageImpl.frames with lock to fix data race in Page.Frames()

pageImpl.frames was written by the connection dispatch goroutine
(onFrameAttached/onFrameDetached) and read by user goroutines via
Page.Frames()/Page.Frame() with no synchronization. Frames() also
returned the internal slice without copying, so callers aliased
memory mutated by the event goroutine.

Guard p.frames with the sync.RWMutex already embedded via
channelOwner, mirroring the existing pattern in browser.go and
browser_context.go. Frames() now returns a copy under RLock, Frame()
iterates a locked snapshot, and onFrameAttached/onFrameDetached
mutate under Lock with Emit kept outside the critical section since
handlers run synchronously and may re-enter Page methods.

Adds a regression test that fails with multiple DATA RACE reports
under -race before this change and passes after.

14 of 14 new or added lines in 1 file covered. (100.0%)

8770 of 11097 relevant lines covered (79.03%)

14542.45 hits per line