mtlynch / GreenPiThumb

82%

master: 86%

LAST BUILD ON BRANCH refactored-pollers

branch: refactored-pollers

CHANGE BRANCH

x

Reset

• refactored-pollers
• add-cli
• add-logging
• add-message
• add-now
• add-precommit
• add-yapf
• ansible-instructions
• bring-back-camera
• closable-pollers
• combined-pollers
• config-file-location
• config-parser
• connect-for-real
• contrib-guidelines
• coverage-poc
• cursor-to-connection
• cut-res
• db1
• dbstore-test
• default-sleep-window
• dht11
• docstring-checker
• faster-parsing
• faster-queue-processing
• fix-build
• fix-camera-paths
• fix-light-min
• fix-mcp3008
• fix-naming
• fix-poll-timing
• fix-pre-commit
• fix-quotes
• fix-soil-sensor
• flippy-floppy
• fritzing-diagram
• get-last-pump
• hook-up-db
• hook-up-db2
• hook-up-db3
• humidity_sensor
• humidity_sensor3
• humidity_sensor_conflictsfixed
• ignore
• install-instructions
• last-poll-time
• last-ref
• less-local
• let-charge-dissipate
• let-me-ctrl-c
• master
• merged5
• more-poll-time
• no-future-import
• no-more-picamera
• no-seconds
• p1
• parsing-and-polling
• picamera-readme
• poll-on-boundary
• pollers-connect
• pollers-connect3
• pollers-really-connect
• pump-interval
• record-processor
• record-system
• refactor-db
• refactor-pump
• remove-old-reference
• reorder-checks
• scheduler
• sensor_naming
• simple-dbstore-naming
• soil-wires
• sparkfun-pump
• specify-pump-amount
• thread-safe-adc
• threshold-as-flag
• throwaway1
• upgrade-yapf
• yapf-upgrade

Build # 148

Build Type

push

travis-ci

Committed by mtlynch

Commit Message

Refactoring pollers

The goal of the refactoring is to fix two problems:
1. SensorPollBase has a design flaw in that it runs in the main thread, but
 holds instance data that is meant to be operated on in the background thread.
 This is error-prone because if SensorPollBase touches its members that are
 not thread safe while the background thread is also touching it, we can get
 concurrency bugs. We should redesign it so that it doesn't have access to
 any instance data it shouldn't be touching.
2. There are two ways of instantiating the pollers: through the
 SensorPollerFactory and by instantiating the objects directly. Offering an
 API with multiple ways of doing the same thing is messy, so we're making
 the classes private so that the factory is the only way clients can create
 them. We also rewrite the unit tests to test through the factory so that the
 unit tests are an accurate reflection of how the caller uses the APIs.

Run Details

429 of 524 relevant lines covered (81.87%)

0.82 hits per line