mtlynch / GreenPiThumb

85%

master: 86%

LAST BUILD ON BRANCH closable-pollers

branch: closable-pollers

CHANGE BRANCH

x

Reset

• closable-pollers
• add-cli
• add-logging
• add-message
• add-now
• add-precommit
• add-yapf
• ansible-instructions
• bring-back-camera
• combined-pollers
• config-file-location
• config-parser
• connect-for-real
• contrib-guidelines
• coverage-poc
• cursor-to-connection
• cut-res
• db1
• dbstore-test
• default-sleep-window
• dht11
• docstring-checker
• faster-parsing
• faster-queue-processing
• fix-build
• fix-camera-paths
• fix-light-min
• fix-mcp3008
• fix-naming
• fix-poll-timing
• fix-pre-commit
• fix-quotes
• fix-soil-sensor
• flippy-floppy
• fritzing-diagram
• get-last-pump
• hook-up-db
• hook-up-db2
• hook-up-db3
• humidity_sensor
• humidity_sensor3
• humidity_sensor_conflictsfixed
• ignore
• install-instructions
• last-poll-time
• last-ref
• less-local
• let-charge-dissipate
• let-me-ctrl-c
• master
• merged5
• more-poll-time
• no-future-import
• no-more-picamera
• no-seconds
• p1
• parsing-and-polling
• picamera-readme
• poll-on-boundary
• pollers-connect
• pollers-connect3
• pollers-really-connect
• pump-interval
• record-processor
• record-system
• refactor-db
• refactor-pump
• refactored-pollers
• remove-old-reference
• reorder-checks
• scheduler
• sensor_naming
• simple-dbstore-naming
• soil-wires
• sparkfun-pump
• specify-pump-amount
• thread-safe-adc
• threshold-as-flag
• throwaway1
• upgrade-yapf
• yapf-upgrade

Build # 101

Build Type

push

travis-ci

Committed by mtlynch

Commit Message

Changing poller semantics to make them stoppable

The pollers originally were designed without a way of stopping the background
polling thread. In practice, we probably don't really need a way of closing
the thread, but in unit tests, we need a way of killing the background thread
when the test ends, otherwise the tests spawn a bunch of threads that never
stop running.

I'm not sure why the existing tests never triggered this problem, but when we
change the pollers to be record queue based, I'm seeing this issue, so fixing
the tests ahead of that change.

Run Details

381 of 449 relevant lines covered (84.86%)

0.85 hits per line