msimerson / Haraka

38%

master: 17%

LAST BUILD ON BRANCH net_utils

branch: net_utils

CHANGE BRANCH

x

Reset

• net_utils
• 910-results-string
• 945-convo
• 962-partial-revert
• 987-http-init
• 987-server-http
• Changes
• Travis-docker
• access
• access-logmsg
• access-test
• access-typo
• address
• appveyor
• asn
• asn-docs
• async-1.0
• attachment
• attachment-cfg
• attachment-faster
• auth-results
• auth_base
• auth_base-results
• auth_vpopmail
• avg
• avg-noop
• bounce
• bug_873
• cfreader
• cfreader-cache
• cfreader-cache2
• cfreader-lite
• cfreader-ws
• changes
• changes-prep-2.7.0
• char-encode
• clamav-noop
• clamd-reject
• cleanup-docs
• cleanups
• cleanups-more
• codeclimate
• config-empty-value-permissible
• config-plugins
• config-plugins-docs
• config-plugins-order
• config-tests
• config-type
• configfile
• connect.geoip
• connection
• connection-crash
• connection-dry
• connection-early-talker
• connection-errors
• connection-noop
• connection-queue-msg
• connection-results
• convo
• coveralls
• dev-2.6.2-4
• discard
• dkim
• dkim_sign
• dmarc
• dns_list
• dns_list_base
• dns_utils
• dnsbl-error-msg
• dnswl
• docs
• drop-node-0.8
• dsn_fix-test
• early-talker
• early_talker
• fcrdns
• fcrdns-enodata
• fcrdns-ptr-valid
• fs-watch
• fs-watch-cb
• geoip
• geoip-reportas
• graph-deprecate
• grunt
• haproxy-ipv6
• headers
• headers-two-more
• http-server
• iconv_lite
• iojs
• ipv6-rfc1918
• is_ip_in_str
• karma
• karma-dnsbl
• karma-messages
• karma-mf
• karma-minus-concurrent
• karma-noop
• karma-pruning
• karma-skip-outbound
• karma-tests
• karma2
• limit
• limit.ini
• line-endings
• line_socket
• lint
• log-elasticsearch
• log-reader
• malware-config-speedup
• master
• mfr
• net_utils.get_ipany_re
• net_utils.get_ips_by_host
• node-0.8
• noop
• nosql
• outbound
• outbound-lint
• p0f
• plugin-dir
• plugins
• plugins-from-node_modules
• plugins-test
• plugins.noop
• prep-release-2.7.0
• public-suffix-list
• rcpt.ldap
• rcpt.routes
• readme
• redis-plugin
• regex-improve-ipv6
• relaying
• reponse
• result_store
• result_store-array-array
• result_store-envelope
• result_store-hidden
• results-has-num-bool
• results-redis
• results-string
• routes
• rspamd
• rspamd-bugfix
• rspamd-missing-plugin
• server
• server-http-init
• server-noop
• smtp_client
• smtp_client2
• smtp_client3
• smtp_client4
• smtp_forward
• smtp_forward-noop
• spamassassin
• spf-test-noise
• syslog-strongloop
• test-cleanups
• tls
• tls-notls-after-failure
• toaster
• todo
• toobusy
• travis
• ubuntu
• uribl-call_next
• uribl-doc
• uribl-multiple-callback
• utils
• utils-elapsed
• vim-droppings
• watch
• watch-http
• watch-http-init
• watch-updates
• windows-compat

Build # 1156

Build Type

push

travis-ci

Committed by msimerson

Commit Message

rename net_utils.is_rfc1918 -> is_private_ip

RFC 1918 only specifies the 3 IPv4 private IP blocks. This function has evolved to also include loopback IPs and is likely to continue evolving to add other "Special IP allocations" (RFC 6890) such as the link local netblocks. This name encompasses all those uses.

* adds IPv6 link local to is_private_ip
    * fixes #850
* net_utils: wrap long lines (lint)
* net_utils, added is_local_ipv4, is_private_ipv4, & is_local_ipv6
    * updated is_private_ip to use them
* adds additional test coverage
* considerably easier to maintain than one regex for ipv4 and one for ipv6
* no significant performance impact (0.05 second difference on 2 million iterations)
* side note: using ?: in /regex/.test(str) seems to make no performance different whatsoever (less than rounding error in testing).
* added docs for net_utils.is_local|private_ipv*
* add IPv6 unique local fc00::/7

Run Details

23 of 61 relevant lines covered (37.7%)

1.13 hits per line