moscajs / aedes
100%

DEFAULT BRANCH: main
Repo Added
Token reeIIvLL038Ei5xilzxM6Vs8lvN3OopEW regen
Build 1427 Last
Files 14
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 99.572%. Remained the same
16285713122

push

github

web-flow 
feat: automate benchmark on PR requests using Github Actions (#1037)

This PR adds Github actions to automate benchmark running on PR requests

It will create a [Github Job
Summary](https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/)
of the benchmark and add it to the benchmark action (see
https://github.com/moscajs/aedes/actions/runs/16239498783#summary-45853979456
)

The benchmark steps run serialized in the hope that performance on a
single runner does not vary too much.
I have been building testing this using
https://github.com/seriousme/aedes/pull/1 which also shows how it
operates.

It also shows that variation between results is inevitable, even when
running on the same runner and the Aedes code is identical !!

In https://github.com/seriousme/aedes/pull/1 I was able to add the
comment automatically to the PR using
`.github/actions/sticky-pr-comment/action.yml` however if you send a PR
from a fork the GITHUB_TOKEN that runs the actions by default (event:
[pull_request](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request)
) only has `read` access on the PR for security reasons (see [Pull
Request events for forked
repositories](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories))

This can be fixed by attaching to the event:
[pull_request_target](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target),
however Github notes explicitly: *Avoid using this event if you need to
build or run code from the pull request.*

So for now I used Github Job Summary instead.

Kind regards,
Hans

---------

Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>

337 of 341 branches covered (98.83%)

Branch coverage included in aggregate %.

827 of 828 relevant lines covered (99.88%)

22902.61 hits per line

Relevant lines Covered
828 RELEVANT LINES 827 COVERED LINES
22902.61 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16285713122 main feat: automate benchmark on PR requests using Github Actions (#1037) This PR adds Github actions to automate benchmark running on PR requests It will create a [Github Job Summary](https://github.blog/news-insights/product-news/supercharging-gith... push web-flow github
99.57
16285704114 github-action-benchmark-compare Merge 27c20a556 into f6a09bfa7 Pull #1037 web-flow github
99.57
16285111941 github-action-benchmark-compare Merge 05b3b4926 into f6a09bfa7 Pull #1037 web-flow github
99.57
16277526270 github-action-benchmark-compare Merge 4accfc049 into f6a09bfa7 Pull #1037 web-flow github
99.57
16277474336 github-action-benchmark-compare Merge 35e286c71 into f6a09bfa7 Pull #1037 web-flow github
99.57
16267259002 main feat!: migrate to async persistence (#1034) This PR migrates Aedes to use the async persistence interface. It contains the following sub items: - [X] replace all callback calls to persistence by `.then()` calls - [X] move all side effects (sett... push web-flow github
99.57
16265045322 migrate-persistence-to-async Merge 79824a503 into 04e391fee Pull #1034 web-flow github
99.57
16239498778 github-action-benchmark-compare Merge 233ed77cf into 04e391fee Pull #1037 web-flow github
99.57
16239327638 github-action-benchmark-compare Merge 479c2740b into 04e391fee Pull #1037 web-flow github
99.57
16236983890 github-action-benchmark-compare Merge 16180ae70 into 04e391fee Pull #1037 web-flow github
99.57
See All Builds (440)

Badge your Repo: aedes

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh