moonbitlang / core
89%
main: 89%

LAST BUILD BRANCH: hongbo/fix_bench_api
DEFAULT BRANCH: main
Repo Added
Files 258
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH hongbo/sorted_set_behavior_change
branch: hongbo/sorted_set_behavior_change
CHANGE BRANCH
x

coverage: 89.187% (-0.004%) from 89.191%
1454

Pull #2805

github

bobzhang 
refactor(immut/sorted_set): Change Compare implementation to compare by size first

BREAKING CHANGE: The Compare trait implementation for SortedSet now compares
sets by size first before comparing elements lexicographically. This is a
semantic change from the previous behavior.

Previous behavior:
- Compared sets element-by-element lexicographically
- {1,2} > {3} because 3 > 2 (compared until one iterator exhausted)

New behavior:
- Compares by size first, then by elements if sizes are equal
- {1,2} > {3} because size(2) > size(1)
- Only compares elements lexicographically when sizes are equal

Rationale:
- More intuitive: larger sets are "greater than" smaller sets
- Performance: Size comparison is O(1), avoids unnecessary element iteration
- Consistency: Matches common set comparison semantics in other languages

Changes:
- Refactored iterator-based Eq and Compare implementations to generic.mbt
- Extracted InorderIterator to external_iterator.mbt
- Added comprehensive tests for both same-size and different-size comparisons
- Both implementations now use the external iterator for element traversal

Request for review:
This is a breaking change that affects anyone using Compare/ordering operations
on SortedSet. Please review whether this new semantic is acceptable.
Pull Request #2805: refactor(immut/sorted_set): Change Compare to compare by size first [BREAKING]

24 of 24 new or added lines in 2 files covered. (100.0%)

9271 of 10395 relevant lines covered (89.19%)

193662.05 hits per line

Relevant lines Covered
10395 RELEVANT LINES 9271 COVERED LINES
193662.05 HITS PER LINE
Source Files on hongbo/sorted_set_behavior_change

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1454 hongbo/sorted_set_behavior_change refactor(immut/sorted_set): Change Compare implementation to compare by size first BREAKING CHANGE: The Compare trait implementation for SortedSet now compares sets by size first before comparing elements lexicographically. This is a semantic cha... Pull #2805 bobzhang github
89.19
See All Builds (6666)