ministryofjustice / cla_public

74%

master: 74%

LAST BUILD ON BRANCH better-error-when-backend-broken

branch: better-error-when-backend-broken

CHANGE BRANCH

x

Reset

• better-error-when-backend-broken
• Blank-branch-to-test-pipeline
• Change-staging-backend-connection
• Feature/LGA-2401-update-income-disregard-help-content
• Feature/lga-2457-thirdparty-confirmation-email-with-welsh
• Improve-google-maps-destination-lookup
• LGA-1620-Welsh-character-counts
• LGA-1624-welsh-privacy-update
• LGA-1649-Welsh-info-stored-message
• LGA-1687-mediation-welsh
• LGA-1707-Welsh-means-fail
• LGA-1710-Welsh-means-fail
• LGA-1717-refactor-user-session
• LGA-1737-Welsh-CLA-unavailable
• LGA-1938-remove-deprecated-extensions-ingress-api
• LGA-1958-public-staging-live-1-cleanup
• LGA-2734-upgrade-jquery
• LGA-2847-ga-load-time
• LGA-2994-Update-CircleCI-images
• LGA-2997-fala-ga
• LGA-3022-GA4-error-pages
• LGA-3027-display-postcode-errors
• LGA-3075-ga4-new
• LGA-3175-add-GA4-events
• New-manual-translation-process
• WIP-LGA-1959-CLA-Public-Production-Live-1-Clean-up
• WIP/LGA-2451
• add-architecture-diagram-to-readme
• bug/Append-team-name-to-modsecurity
• bug/Fix-FALA-misdirect
• bug/LGA-1118-page-length-fix
• bug/LGA-2264-IO-error
• bug/LGA-2907-contact-page-error-message
• bug/LGA-2911-updating-sign-language-url
• bug/LGA-2972-Resolve-failed-to-load-cla-public-staging-dashboard
• bug/LGA-3047-postcode-input-disapearing-when-invalid-postcode-entered
• bug/LGA-3339-fix-add-property-button
• bug/add-in-additional-logging
• bug/disable-callbacks-for-28th-July
• bug/disable-callbacks-for-today
• bug/remove-sec-rule-sql
• cfe-integration
• dependabot/npm_and_yarn/accessibility_tests/brace-expansion-1.1.12
• dependabot/npm_and_yarn/accessibility_tests/multi-a3682516e4
• dependabot/npm_and_yarn/accessibility_tests/tmp-0.2.4
• dependabot/npm_and_yarn/cipher-base-1.0.6
• dependabot/npm_and_yarn/engine.io-6.2.0
• dependabot/npm_and_yarn/follow-redirects-1.15.6
• dependabot/npm_and_yarn/http-proxy-1.18.1
• dependabot/npm_and_yarn/pbkdf2-3.1.3
• dependabot/npm_and_yarn/sha.js-2.4.12
• dependabot/npm_and_yarn/yargs-parser-5.0.1
• dependabot/pip/markdown2-2.3.9
• dependabot/pip/requirements/generated/pyyaml-5.4.1
• dependabot/pip/requirements/generated/urllib3-2.5.0
• featuer/LGA-1246-gtm-staging-code
• feature-LGA-1326-aria-expanded
• feature-LGA-1600-updated-privacy
• feature/LGA-1008-trigger-on-consent
• feature/LGA-1017-non-prod-landing-page
• feature/LGA-1053-frontend-approach
• feature/LGA-1053-operator-hours
• feature/LGA-1074-currency-input
• feature/LGA-1074-pound-sign
• feature/LGA-1074-£-sign
• feature/LGA-1078-text-number
• feature/LGA-1082-flee
• feature/LGA-1085-helm
• feature/LGA-1095-flee
• feature/LGA-1099-ga
• feature/LGA-1106-family-mediation-question-change
• feature/LGA-1107-ie-details-tag-bug
• feature/LGA-1119-change-GA-language-field-on-welsh-pages
• feature/LGA-1123-80010
• feature/LGA-1134-helm-production
• feature/LGA-1158-escape
• feature/LGA-1159
• feature/LGA-1159-staging-ingress
• feature/LGA-1160-flake8-regression
• feature/LGA-1162-hidden-field-error
• feature/LGA-1163-enable-production-ingress
• feature/LGA-1170-no-options
• feature/LGA-1175-COVID19-hours
• feature/LGA-1175-plague-hours
• feature/LGA-1176-FALA-link
• feature/LGA-1180-saturday-slots
• feature/LGA-1212-CSS-tidy-up
• feature/LGA-1213-Circle-CI-approval
• feature/LGA-1218-welsh
• feature/LGA-1227-welsh-bug
• feature/LGA-1230-always-passing-tests-bug
• feature/LGA-1236-remove-moj-ga
• feature/LGA-1249-n62
• feature/LGA-1252-restore-ga
• feature/LGA-1253-timeout-message-welsh
• feature/LGA-1264-gtm-staging-and-master
• feature/LGA-1265-alt-text
• feature/LGA-1268-gtm-preview-value
• feature/LGA-1273-pseudo-start-page
• feature/LGA-1279-currency
• feature/LGA-1283-partner-error-messages
• feature/LGA-1284-QE-wording
• feature/LGA-1295-missing-translation
• feature/LGA-1295-translation-missing
• feature/LGA-1296-QE-accessibility
• feature/LGA-1298-no-options
• feature/LGA-1304-green-button
• feature/LGA-1314-no-option-tracking
• feature/LGA-1315-production-env-setting
• feature/LGA-1317-tag
• feature/LGA-1319-Firefox
• feature/LGA-1321-duplicate-IDs
• feature/LGA-1322-0
• feature/LGA-1325-fieldset
• feature/LGA-1327-quick-exit
• feature/LGA-1333-colours
• feature/LGA-1333-map-test
• feature/LGA-1339-spike-1
• feature/LGA-1339-spike-2
• feature/LGA-1340-currency-input-fields
• feature/LGA-1341-more
• feature/LGA-1342-property
• feature/LGA-1343
• feature/LGA-1347-maintenance-page
• feature/LGA-1353-message
• feature/LGA-1355-timeout
• feature/LGA-1357-character-counter
• feature/LGA-1358-GDS
• feature/LGA-1363-opening-hours
• feature/LGA-1363-opening-times
• feature/LGA-1377-sentry-sdk
• feature/LGA-1384-error
• feature/LGA-1389-enable-maintenance-mode
• feature/LGA-1398-family-route-colour-bar
• feature/LGA-1402-external-links
• feature/LGA-1403-title
• feature/LGA-1404-address-entry
• feature/LGA-1404-comms
• feature/LGA-1407-numbers
• feature/LGA-1413-Henry-V
• feature/LGA-1427-accessiblity-statement-update
• feature/LGA-1428-welsh
• feature/LGA-1436-use-new-staging-domain
• feature/LGA-1441-web-and-phone-72hours-sla--test-area
• feature/LGA-1446-uwsgi-io-error
• feature/LGA-1455-Saesneg-in-English
• feature/LGA-1463-graceful-termination
• feature/LGA-1475-double-H1
• feature/LGA-1479-erratic-select
• feature/LGA-1485-behaviour-page
• feature/LGA-1508-button-margin
• feature/LGA-1509-test-happy-path-with-webhint
• feature/LGA-1509-webhint-happy-path-test
• feature/LGA-1511-LARP-link-focus
• feature/LGA-1511-LARP-map-focus
• feature/LGA-1515-sign-lang-for-blind
• feature/LGA-1538-erratic-selects
• feature/LGA-1541-LARP-title-bug
• feature/LGA-1542-remove-mortgage-cap
• feature/LGA-1543-install-and-integrate-cypress
• feature/LGA-1547-backup-disregards
• feature/LGA-1548-GDS-design-system
• feature/LGA-1567-closed-on-boxing-day-2020
• feature/LGA-1570-LARP-modern-slavery
• feature/LGA-1570-larp-modern-slavery-route
• feature/LGA-1574-reinstate-noisy-uwsgi-logging
• feature/LGA-1579-Welsh-disregards
• feature/LGA-1585-LARP-slavery-bug
• feature/LGA-1586-opening-hours-welsh
• feature/LGA-1587-OS-maps
• feature/LGA-1589-valuable-items
• feature/LGA-1609-integrate-axe-core
• feature/LGA-1623-Welsh-accessibility-statement
• feature/LGA-1629-os-places-api-update
• feature/LGA-1631-message-switch
• feature/LGA-1636-display-full-summary
• feature/LGA-1637-larp-modern-slavery-label
• feature/LGA-1638-use-backend-static-uat
• feature/LGA-1674-mediation-question
• feature/LGA-1680-adding-survey
• feature/LGA-1685-emergency-message-template
• feature/LGA-1693-add-smart-survey-production
• feature/LGA-1699-remove-intent-survey
• feature/LGA-1719-update-cla-common
• feature/LGA-1749-update-gds-styles
• feature/LGA-1753-family-changes
• feature/LGA-1812-change-thickness-of-links
• feature/LGA-1853-welsh-translation-eligible-result-page-for-family
• feature/LGA-1895-ingress-annontation
• feature/LGA-1914-remove-setup-kube-auth
• feature/LGA-1966-Add-end-2-end-tests-to-circle-ci
• feature/LGA-1968-semgrep
• feature/LGA-2049-implement-waf-monitor-only
• feature/LGA-2083-add-maintainance-mode-page
• feature/LGA-2125-update-ingress-version
• feature/LGA-2149-privacy-notice-update
• feature/LGA-2220-trapped-capital-content
• feature/LGA-2229-welsh-trapped-capital
• feature/LGA-2267-communicate-to-backend
• feature/LGA-2299-maintenance-banner
• feature/LGA-2306-enable-full-modsec-ruleset
• feature/LGA-2350-accessibility-testing
• feature/LGA-2393-trigger-artifacts
• feature/LGA-2423-update-base-images
• feature/LGA-2451-update-email-to-use-notify
• feature/LGA-2454-send-welsh-emails-in-notify
• feature/LGA-2457-third-party-confirmation-email
• feature/LGA-2585-circleci-irsa
• feature/LGA-2612-bump-govuk-frontend-css
• feature/LGA-2730-secure-cookies
• feature/LGA-2730-secure-cookies-and-headers
• feature/LGA-2734-upgrading-jquery
• feature/LGA-2768-Enable-communication-between-CLA_Public-and-Email-Orchestrator
• feature/LGA-2788_Remove_old_notify_client_code
• feature/LGA-2798-announce-calling-cla
• feature/LGA-2897-dockerize-project
• feature/LGA-2920-hlpas-check-changes
• feature/LGA-2931-correct-contact-content
• feature/LGA-2976-update-govuk-frontend
• feature/LGA-2986-403-error-page
• feature/LGA-2991-hide-non-prod
• feature/LGA-3005-Callback-capping
• feature/LGA-3016-call-capping-threshold-alert--test
• feature/LGA-3026-Redesign-find-a-legal-advsior-page
• feature/LGA-3026-change-refer-to-legal-advisors-results-page
• feature/LGA-3027-hlpas-page-after-means
• feature/LGA-3154-bsl-start-button
• feature/LGA-3158-bsl-contact-change
• feature/LGA-3200-contact-phone-number-cache-value-fix
• feature/LGA-3321-Check-list-disregard
• feature/LGA-3322-mtr-change-property
• feature/LGA-3322-mtr-property-desc-change
• feature/LGA-3553-Change-check-privacy-policy
• feature/LGA-3575-Update-survey-link
• feature/LGA-3580-routing-cookie-setup
• feature/LGA-455-tech-debt-simplify-get-cait-params
• feature/LGA-456-tech-debt-remove-cyclomatic-complexity
• feature/LGA-807-cookies
• feature/LGA-940-errors
• feature/LGA-955-unimplemented-method-post
• feature/LGA-956-errors
• feature/LGA-989-contact-session
• feature/LGA-989-restart-session-for-contact
• feature/LGA-990-translate-contact-options-dropdown
• feature/LGA-990-welsh-dropdowns
• feature/QE-testing
• feature/WIP-LGA-387-accessibility-statement
• feature/check_ingress_13_sep
• feature/clear-cache
• feature/jo-check-ingress
• feature/legal-aid-available-page
• feature/lga-2457-thirdparty-confirmation-email-with-welsh
• feature/new-sentry
• feature/quick-exit-tweaks
• feature/user-research
• fix/LGA-2604-Fixed-positioning-of-exit-button
• ingress-dashboard
• ingress-toggle
• install-improvements
• install-python2-with-pyenv
• invesitagte-circle-rot
• kylebranch/copy-remove-me-when-done
• lga-2229-welsh-trapped-capit
• lga-2604
• lga-2647
• lga-2700
• lga-3666-modsec-upgrade
• m1-e2e-public-fixes
• maintenace-mode-test
• malcolm-testing
• master
• pipeline-e2e-oidc-update
• pre-start-page-probing
• prisma-dynamic-stage-test
• pull-shared-laa-ips
• revert-984-feature/LGA-1347-maintenance-page
• revert-997-feature/LGA-1389-enable-maintenance-mode
• rowlando-patch-1
• rowlando-semgrep
• said-switch-to-default-ingress-controller
• saids-test-indicator-test-branch
• snyk-fix-038f345e8d3e24267321eff71ddd7980
• snyk-fix-3f06e9671a1c9264fe415d7826084bdd
• snyk-fix-546cb0f6ba5cf90a89dc5b6dfc877b8f
• snyk-fix-652652e1d887d7f72bfd8949bf4a2cdf
• snyk-fix-a414045ec2725ffec39e6a48ed9796bd
• snyk-fix-c1db8cf7e3467cde638c40f18ab111a3
• snyk-fix-c990ce64f281b9df5af06c0df62630d5
• snyk-fix-f7f616be7217f5bf107a3d3a9bf08c02
• snyk-upgrade-a4de05bddc16237cb7e3f575de4e4424
• snyk-upgrade-be5bb1ea32c8e4a8754831b6e2a05346
• snyk-upgrade-c93eb4b7744cbd325ec6624f749e780a
• snyk-upgrade-d7aef86444803e8afed8fcd4d8785054
• spike/LGA-2128-Update-base-image
• spike/LGA-2263-ModSec-investigations
• switch-default-controller-no-downtime
• update-build-job-docker-image
• use-backend-k8-staging-environment

Build # 20572

Build Type

Pull #1240

circleci

Committed by davidread

Commit Message

Better error message when backend broken

When backend returns 500 error, then lets raise an exception for that,
rather than ignore it and raise it on the next line when we JSON decode
the blank response.

post_to_scope() gets called in two places:

1. create_diagnosis() immediately does response.json(), and the current behaviour is for the ValueError() to bubble up through the View (ScopeDiagnosis.get()) and the user gets a 500 error page. So this PR changes that to a HTTPError. The user sees the same thing, but a developer user benefits from the nicer error, saying what the problem URL was etc

2. move() returns the response to ScopeDiagnosis.get(), which does response.json(), but catches the ValueError, in debug mode returns the text, but otherwise reraises it. So this PR means an HTTP error will be raised marginally earlier, but basically unchanged.

Pull Request Pull Request #1240: Better error message when backend broken

Run Details

0 of 3 new or added lines in 1 file covered. (0.0%)

2169 of 2927 relevant lines covered (74.1%)

0.74 hits per line