ministryofjustice / cla_public / 20572

74%

master: 74%

Pull #1240

circleci

Better error message when backend broken

When backend returns 500 error, then lets raise an exception for that,
rather than ignore it and raise it on the next line when we JSON decode
the blank response.

post_to_scope() gets called in two places:

1. create_diagnosis() immediately does response.json(), and the current behaviour is for the ValueError() to bubble up through the View (ScopeDiagnosis.get()) and the user gets a 500 error page. So this PR changes that to a HTTPError. The user sees the same thing, but a developer user benefits from the nicer error, saying what the problem URL was etc

2. move() returns the response to ScopeDiagnosis.get(), which does response.json(), but catches the ValueError, in debug mode returns the text, but otherwise reraises it. So this PR means an HTTP error will be raised marginally earlier, but basically unchanged.

0 of 3 new or added lines in 1 file covered. (0.0%)

2169 of 2927 relevant lines covered (74.1%)

0.74 hits per line