mbland / url-pointers

95%

master: 98%

LAST BUILD ON BRANCH auth-fixups

branch: auth-fixups

CHANGE BRANCH

x

Reset

• auth-fixups
• master
• refactor-db
• app-helper
• get-redirect
• record-access
• update-db-interface
• supertest
• info-api
• user-integrity
• auth-helpers
• config
• auth-config-refactor
• auth-prep
• auth
• create-api
• complete-api
• smoke-test-timeout
• rm-aws
• serve-script
• mocha-ui
• mocha-phantomjs
• travis-browser
• coverage
• separate-bundles
• local-assets
• test-cov-err-msg
• ui-init
• ui-templates
• ui-fade
• ui-flash
• ui-create-link
• ui-create-link-touchup
• ui-fix-fade
• ui-focus
• ui-create-link-handler
• browser-coverage
• coverage-config
• launch-all
• test-auth
• mocha-phantomjs-core
• test-session
• test-port
• end-to-end
• setup
• test-scripts
• move-tests
• test-focus
• es6ify
• coverage-middleware
• coverage-json
• karma
• test-refactor
• karma-auto-watch
• ubuntu-tweaks
• setup-win32
• fix-win32
• setup-fixes
• karma-browsers
• coverage-browser
• wsl-disable-karma
• fix-karma-setup
• env-template
• live-server-shutdown
• npm-v5.0.0
• browser-test-server
• setup-tweaks
• fix-package-lock
• update-package-lock
• travis-npm
• restore-npms
• redis-fix
• take-screenshot
• e2e-fixture
• show-existing-owner
• user-id
• login-logout
• reformat
• rename

Build # 57

Build Type

push

travis-ci

Committed by mbland

Commit Message

auth: Rename functions to makeUser{Des,S}erializer

While trying to run the app with actual Google OAuth authentiation, the
OAuth callback request would hang. I eventually realized it was because
I'd written auth.serializeUser and auth.deserializeUser as factory
functions, but was passing them directly to passport.serializeUser() and
passport.deserializeUser(). Invoking the factory functions resolved the
hangup.

To avoid such confusion in the future, I've renamed the factory
functions to makeUserSerializer and makeUserDeserializer.

Run Details

99 of 106 branches covered (93.4%)

Branch coverage included in aggregate %.

293 of 307 relevant lines covered (95.44%)

11.93 hits per line