mapbox / mapbox-gl-js

88%

master: 92%

LAST BUILD ON BRANCH bindpopup-2

branch: bindpopup-2

CHANGE BRANCH

x

Reset

• bindpopup-2
• 0.27.0-plugins
• 0.44
• 1466-non-mercator
• 1ec5-cubic-bezier-doc-y1
• 1ec5-docs-intro-monorepo
• 1ec5-filter-toc-link
• 1ec5-ios-v3.6.0-macos-v0.5.0
• 1ec5-language-plugin
• 1ec5-macos-v0.4.0
• 1ec5-max-renderbuffer-ff-3915
• 1ec5-readme-logo
• 1ec5-source-docs-smoke-3267
• 1ec5-style-spec-doc-nits
• 1ec5-style-spec-ios-v3.5.0
• 1ec5-token-default-104
• 1ec5-token-selection-104
• 1ec5-zanabazar
• 1ec5-縱排-7114
• 2467
• 2827-fill-zoom-and-property-fns
• 3040
• 3081
• 3131
• 3365
• 3386-minor-fix
• 3386-worker-reparse
• 3414-followup
• 3456-no-negative-extrusions
• 3604
• 3612
• 3617
• 3663
• 3803
• 3819
• 3903
• 3d-buildings
• 4008-followup
• 4008-followup-alternate-fix
• 4022-fix-geojson
• 4040-source-immutable
• 4637-addImage-pixelRatio
• 4637-addImage-pixelratio
• 4660-fix-pattern-flicker
• 4661-icon-size-docs
• 4728-symbol-icon-attrib-order
• 4740-url-transform
• 4743-light-anchor-doc
• 4767-animate-point-along-route-example
• 4794-attribute-bindings
• 4980-categorical-order
• 4999-identity-enums
• 5300-canvas-flip
• 5357-fix-debug-z
• 5490-workaround
• 5714-race
• 5720-shaders
• 5875-constants-cleanup
• 5914-world-copies
• 7319-query-with-filter
• Add-scale-control
• AndyMoreland-bugfix/remove-and-re-add-background-layer
• LngLatcheck
• a_pos_normal
• access-token
• add-expression-render-tests
• add-gl-draw
• add-new-geometry-example
• add-scale-docs
• addimage
• advanced_token_formatting
• airport-rotate
• ajax-requestType
• along-line-label-legibility
• anandthakker-more-flow
• andrewharvey-2071-jump-world0
• andrewharvey-patch-1
• andrewharvey-popup-offset
• andrewharvey-update-roadmap
• android-v5.1.0-support-table
• animate-camera-position-helpers
• animate-point-example
• any-all
• api-cleanup
• api-doc-links
• api-doc-updates
• areTilesLoaded-fix
• arity-tests
• atlases
• attribution-update-guard
• avoid-reusing-var-name-in-results-html
• axonometric-testing
• backport-6068
• bail-zero-opacity
• batfish
• bearing
• bench-runner
• bench-table
• benchmark-master
• benchmark-sample-data
• benchmark-share
• benchmarks
• benchmarks-effect-size
• benchmarks-readme
• better-ci-caching
• better-colors
• better-uglify
• better-worker-count
• bind-popup
• blanchg-polygon-centroid-labels-1231
• boundsj-add-regression-test-8078
• box-zoom-fix
• brandonbloom-serialize-options
• bublé
• bucket-addFeature
• bucket-interface
• bump-directions
• bump-node
• bump-nyc
• bump-rtl-text-version
• bundler-update
• cache-eslint
• cache-evaluation-ctx
• cache-handle-expired
• cache-nyc
• canvas_fix
• cdawi-master
• changelog
• checkSubtype
• china
• ci-on-osx
• ci-upload-images
• circle-macos
• circle-parallel
• circle-stroke
• circle-xcode-fix
• cjk-break
• cjk-break2
• cjk-overflow
• clarify-docs
• clarify-interval-stops
• clarify-stop-output-value
• clean-dependencies
• cleaner-debug-pages
• cleanup-deps
• cleanup-docs-deps
• cleanup-pattern
• cleanup-sprite
• cleanup-urls
• clip-raster
• cloer-4054-regression
• cloer-5776
• cloer-5993
• cloer-5995
• cloer-6002
• cloer-avoid-tile-debug
• cloer_3346
• cloer_4617
• cloer_4720
• cloer_4860
• cloer_5090
• cloer_5112
• cloer_5172
• cloer_5248
• cloer_5496
• cloer_5516
• cloer_5544
• cloer_5546
• cloer_5554
• cloer_5620
• cloer_5837
• cloer_arabic
• cloer_cherry_pick_rtl_text_doc_changes
• cloer_circle_pitch_alignment
• cloer_constrain_pitched_symbol_query_test
• cloer_enable_9272_tests
• cloer_enable_9457_tests
• cloer_enable_native_circle_pitch
• cloer_enable_spacing_test
• cloer_enable_tests_9345_9456
• cloer_fix_dead_doc_link
• cloer_icon_pitch_alignment
• cloer_ignore_4860
• cloer_leastbad_linebreak
• cloer_linebreak_backport
• cloer_mb_pages_doc_fix
• cloer_no_arabic_letter_spacing
• cloer_perspective_symbol_queries
• cloer_pitched_native_tests
• cloer_port_getsegmentglyphs
• cloer_reenable_pitched_tests
• cloer_regression_4246
• cloer_remove_dead_buffer_code
• cloer_remove_git_dep
• cloer_rtl_studio_docs
• cloer_rtl_text_npm_move
• cloer_sdk_support_typo
• cloer_text_font_chinese
• cloer_text_pitch_scale
• cloer_upright_labels
• clusters-example
• cn-pages
• collision-box-fix
• collision-circle-perspective-followup
• collision-groups
• collision-port-back
• collision-tile-fixes
• color-interpolation
• compare
• compass-drag-rotate
• control-docs
• controlify
• copy-fix
• cp-6248
• csp-safe
• ctsi-types
• curve-step-interpolate
• dagjomar-patch-2
• dash-line-width-fix
• data-events-revamp
• dataloading
• datastart
• davidtheclark-patch-1
• davidtheclark-patch-2
• dds-heatmap-radius
• dds-line-join
• dds-linejoin-spec
• dds-symbol-paint-2
• dds-text-anchor
• dds-text-font
• dds-text-justify
• dds-text-letter-spacing
• dds-text-max-width
• dds-to-constant-fix
• dead-image-source-code
• dead-vao-code
• debug-collision-fix
• debug-coveralls
• debug-deploy
• debug-matrix-cleanup
• dedupe-video
• deploy-cn
• deploy-env-fix
• description-markdown
• destroy-gl
• detect-insecurity
• dev-pages
• directions-plugin-isc
• div-to-img
• doc-improvements
• docs-formatting
• docs-search-with-description
• document-architecture
• document-getElement
• document-operators
• document-scheme
• documentation.yml
• dom-test2
• downcase-sections
• drag-events
• draw-0.17.4
• draw-cdn-0-14-0
• draw-cdn-0.16
• draw-v1.0.0
• dry-set-pattern
• durran-api-url-with-path
• earcut-final-v0.16.0
• emit-errors
• enable-4150-tests
• enable-8007-tests
• enable-image-source-tests
• enable-image-tests-for-native
• enable-native-tests
• enable-regression-test-2929
• enforce-bounds
• es6-classes
• es6-conventions
• es6-struct-array
• eslint3
• event-chores
• ex-marker-list
• ex-toggle
• example-3rd-party-mvt
• example-links
• example-links-nb
• example_flicker_workaround
• examples-geolocate
• expired-raster-warmfix
• explicit-passes
• expression-doc-amendments
• expression-docs
• expression-enums
• expression-runtime-styling-tests
• expression-test-ignores
• expression-type-docs
• expressions
• expressions-docs-fix
• expressions-examples
• expressions-filter-no-convert
• expressions-other-contexts
• expressions-refactor
• expressions-spec
• expressions-type-errors
• extrusion-opaque
• extrusion-shader-cleanup
• extrusions-clamp-negative
• extrusions-native-tweaks
• fake-canvas
• faster-cover
• feature/expressions
• feedback-info
• fewer-bucket-members
• file-dependency
• fill-extrusion-base
• fill-extrusion-type
• fill-layer-property-function
• filter-benchmark
• filter-docs
• filter-id
• fire-popup-close
• fit-bounds-single-point
• fit-feature
• fix-3264
• fix-3507
• fix-3910
• fix-4104
• fix-4172
• fix-4218
• fix-4235
• fix-4605
• fix-4651
• fix-4670
• fix-4789
• fix-4928
• fix-5133
• fix-5145
• fix-5312
• fix-5326
• fix-5346
• fix-5370
• fix-5426
• fix-5431
• fix-5543
• fix-5580
• fix-5609
• fix-5630
• fix-5631
• fix-5637
• fix-5651
• fix-5674
• fix-5700
• fix-5704-bad-merge
• fix-5711
• fix-5712
• fix-5740
• fix-5752
• fix-5755
• fix-5770
• fix-5772
• fix-5777
• fix-5800
• fix-5802
• fix-5827
• fix-5857
• fix-5862
• fix-5871
• fix-5953
• fix-5968
• fix-5975
• fix-5985
• fix-6011
• fix-6016
• fix-6063
• fix-6118
• fix-6206
• fix-6284
• fix-6576
• fix-6585
• fix-8460
• fix-attribution
• fix-attribution-position-example
• fix-benchmarks
• fix-build
• fix-build-script
• fix-ci-coverage
• fix-circle-artifacts
• fix-circle-query-tile-boundary
• fix-constrain
• fix-dateline-easing
• fix-debug
• fix-deploy
• fix-doc-hashes
• fix-docs
• fix-docs-rebase
• fix-dumb-regression
• fix-expression-debug
• fix-extrusions-clearColor
• fix-flaky-camera-test
• fix-flow-nyc-coverage
• fix-get-default-position
• fix-ie11-startswith
• fix-jsdoc-typo
• fix-layer-flash
• fix-line-rendering
• fix-lint
• fix-lnglatbounds-docs
• fix-loaded
• fix-marker-lag
• fix-mb-pages
• fix-newline
• fix-pitch-0
• fix-popup-toggle
• fix-query-tile-boundary
• fix-raster-alpha
• fix-raster-parent-finding
• fix-reload-symbol-error
• fix-show-tiles
• fix-sort-stops
• fix-spacing-errors
• fix-spacing-issue
• fix-test-path
• fix-text-garbling
• fix-touch-zoom
• fix-transferables
• fix-type-links
• flow
• flow-0.54.1
• flow-config
• flow-def
• flow-ignore
• flow-remove-types-dependency
• flow-types
• flow-types-style-spec
• flow-worker
• flyto-fix
• follow-up-to-5679
• fullscreen-ff
• function-boolean
• function-expression-benchmarks
• function-no-identity-zoom
• function-test-fix
• game-controls
• geocoder-after-result-example-fix
• geocoder-min
• geocoding-docs
• geolocation-icon
• gh-pages
• gl-draw-example-with-events
• gl-style-composite-conflicting-source-layers
• gl-style-composite-documentation
• gldraw-example-bump-version
• glyphs-docs
• group-expression-docs
• group_by_layout
• growing-buildings-ex
• handle-bad-hashes
• hash-pitch
• heatmap-half-float-tests
• heatmaps
• heatmaps-anandthakker
• heatmaps-no-query
• hide-empty-attribution
• hide-private-stuff
• hillshade
• hillshade-pixel-align
• holmari-holmari/listener_error_handling
• ibesora-mapzen-terrain
• ibesora-raster-dem-max-zoom-level
• icon-image-dds
• icon-image-deets
• icon-offset-dds
• icon-offset-docs
• icon-text-size-tests
• iconOffset
• identity-function
• ie-11
• ie-wordmark
• ignore-image-add-alpha
• ignore-query-test
• ignore-render-failures
• image-source-tile
• image-update-tests
• improve-batch-updates
• improve-hash-precision
• improve-keyboard
• in-publish
• inline-postMessage
• integration-test-errors
• integration-tests-better-hiding
• invalid-before
• is-loaded
• isCompleteFunctionBody
• issue-2936
• issue-2936-part-2
• issue-template-title
• jingsam-rename-lru-cache
• jsdom-11
• jsdom-canvas
• layer-query-polymorphism
• layer-vs-sourceLayer
• layer_bench
• layer_bench_multiple
• lbud-annotated
• license-correction
• light-transitions
• line-artifacts
• line-capjoin-dds
• line-dash-opacity-dds
• line-dasharray/zoom-history
• line-prop-identity
• line2
• linewidth-dds-table
• link-tutorials
• lint-object-assign
• loadimage-docs
• local-dependency
• locate-user-example
• lodash-isequal
• logical-buffer-segmentation
• logo-setter
• logocontrol-cleanup
• logoposition-docfix-nb
• lucaswoj-patch-1
• map-mode-render-tests
• map-stacks
• mapbox-gl-compare@v0.1.0
• mapbox-gl-draw-v0.12.0
• mapbox-gl-draw-v0.12.1
• mapbox-gl-geocoder@v1.3.1
• mapbox-gl-inspect
• mapbox-gl-native#7714
• mapbox-gl-native#8007
• mapbox-gl-native#8303
• mapbox-gl-native#8871
• mapbox-gl-native#8952
• mapbox-gl-native#9557
• mapbox-gl-native#9792
• mapbox-gl-native-8505
• mapbox-gl-style-spec-v9-fast-stable-stringify
• mapbox-scope
• mapboxgl-supported-example
• marker-default-element-offset
• marker-eslint
• marker-subpixel-transform
• master
• mb-pag
• mb-pages
• mcwhittemore-patch-1
• merge-function
• merge-mb-pages
• merge-release
• merge-test-suite-debug
• microbenchmarks
• more-flow
• more-moving
• more-runtime-styling-tests
• mozFullScreenEnabled
• multiple-geometry-ex
• multiple-geometry-example
• multipoint-symbol-placement
• native-dds
• native-dds-text-field
• native-fill-extrusion-tweaks
• native-integration-non-debug
• native-queryrenderedfeatures
• native-test-suite-update
• nb-3rd-party-mvt
• new-logo
• no-convert
• no-destructuring
• no-eval-expressions
• no-lazy-stops
• no-program-defines
• no-webpack
• node-6.10.0
• node-6.10.1
• node7
• not-found
• npm-css
• null-equality-expression
• numeric-precision
• nyc-all
• object-deoriented-controls
• object-operator
• off-center-symbols-test
• oguiter-master
• optimize-background
• optimize-draw-fill
• optimize-draw-symbol
• optimize-line-draw
• optimize-render-tests
• optimize-update
• paint-benchmarks
• patch-0.40.1
• pattern-texsize
• perf-5208
• pick-geocoder
• pin-eslint
• pitched-image-source-test
• plug-leaks
• plugin-data
• plugin-example-links
• plugin-updates
• plugins-versions
• point-from-geocoder-result
• popup-blurriness
• popup-close-arialabel
• popup-tests
• pr-template
• prefix-css
• preinstall-fix
• preserve-extrusion-depth
• product-naming
• program-class
• program-configuration
• property-function-line
• property-refactor
• qrf-error-layer
• qrf-no-style
• qrf-visibility-docs
• queryRenderedFeatures-bug
• quickstart-revamp
• raster-3519
• raster-dem-flow
• raster-hillshade
• raster-mask-fix
• raster-source-typo
• rawTileData-cleanup
• readme
• readme-monorepo
• redirect-heatmap-example
• redo-placement
• refactor-easing
• refactor-extrusion-cache
• refactor-transform
• regression-test-native-10849
• regressions-mapbox-gl-native-9900
• regressions-mapbox-gl-native-9976
• regressions-mapbox-gl-native-9979
• reinstate-function-docs
• release-0.40
• release-0.43.0
• release-0.44
• release-ios-v3.5.0-android-v5.0.0
• release-perf
• remove-arrow-func
• remove-babel-react
• remove-expression-key
• remove-expression-name
• remove-imagebitmap
• remove-paint-classes
• remove-plugins
• remove-readme-plugins
• remove-ref
• remove-unpremultiply
• remove-unused
• removeLayer-error
• rename-extrusion-attribs
• render-combinations
• render-overzoomed-tiles
• render-raster-loop
• render-test-diff-gpu
• render-tests-shuffle-seed
• reorg-examples
• rererender
• restore-benchmark-comparison
• retain-all-loaded-chidlers
• revert-3547-multiple-geometry-ex
• revert-5010-line-capjoin-dds
• revert-ajax
• revert-max-renderbuffer-size
• revert-urggg
• rewrite-program-configuration
• rfc
• rm-bin
• rm-class-tests
• rm-enum
• rm-linewidth
• rm-modular-arithmetic
• rm-serialize
• rm-style-zoom
• roadmap
• roadmap-column-descriptions
• roadmap-readme
• roll-back-line-props
• rotate-pitch
• routeline
• run-postinstall
• safari-grr
• scale-cleanup
• sdf-shader-precision
• set-sprite
• set-style-object
• setFilter-linkfix
• setLayers
• setpopup-ex
• shader-funx
• shader-names
• shaders
• shaders-prelude
• shared-tiles
• shelf-pack-v2
• silence-expression-errors
• simplify-bucket
• simplify-calculate
• simplify-dds-attributes
• simplify-regression-test
• simplify-struct-arrays
• single-version-benchmark
• skip-fade-for-setdata
• skip-image-tests-for-native
• slim-gl-matrix
• smooth-mouse-wheel
• sort-program-key
• source-removed-1711
• source-url-query
• sparse-raster
• split-buffer
• sprite-atlas-off-by-one
• sqrt
• state-framebuffers
• state-modes
• state-uniforms
• stepankuzmin-2711-2
• stepankuzmin-3857
• stop-zoom-levels
• strict-categorical-evaluation
• stricter-style-function-type
• string-href-fix
• stringify-colors
• struct-array-fix
• style-guide
• style-layer-require
• style-load-benchmark
• style-set
• style-spec-11
• style-test-cleanup
• styledata-events
• stylelint-readability
• support-imperial-unit
• symbol-bucket
• symbol-cleanup
• symbol-collision-buffers
• sync-0.44
• sync-mb-pages
• sync-release
• sync-with-release
• test-3369
• test-3702
• test-clock
• test-git-lfs
• test-invisible-features-winding
• test-leaks
• test-reporter
• test-result-gitignore
• test-short-circuiting
• test-spew
• test-suite
• test-suite-recyclemap
• test-suite-recyclemap-js-impl
• text-font-chinese
• text-rotate-dds
• text_rotate_dds
• texture-pos-scaling
• third-party-ex-fix
• tile-masking-test
• tile-sort-order
• tilejson-bounds-render-test
• toggle-layer-ex
• token-replacement-docs
• touch-action
• transfer-image
• transition-regression-tests
• transition-test
• tweak-style-layer-create-benchmark
• type-before-test
• type-browser
• type-feature-index
• type-functions
• type-image-sprite
• type-links
• type-render
• type-source
• type-style
• type-style-layer
• type-style-spec
• type-tile-coord
• type-vt
• typed-style-layer
• unexport-logocontrol
• unexport-util
• unignored-tests
• unique-layer-id
• unset-fill-outline-color
• unused-uniforms
• update-contributing
• update-dds-support
• update-default-template
• update-directions-license
• update-draw-cdn
• update-examples
• update-flow
• update-generated
• update-geocoder-plugin
• update-gl-function-version
• update-logo-asset
• update-product-names
• update-shaders
• update-supported
• update-tap
• update-template-mb-pages
• update-test-npm-deps
• update-test-suite
• upgrade-deps
• upgrade-docs-deps
• upgrade-geojson-vt
• upgrade-jsdom
• upgrades
• use-texture-class
• use-token-property
• v0.39.0
• v0.41.0
• v0.42.0
• v0.42.1
• v0.42.2
• v0.43.0
• v0.43.0-beta.1
• v0.44.0
• v0.44.2
• validate-bounds
• validations
• vicapow-flow-style-type
• vicapow-flow-ui-map
• viewport-collision
• viewport-collision-sort
• viewport-collision-tweak
• viewport-symbol-depth
• vt-pbf
• watchify
• watchify3
• web-worker-transfer
• webkit-fullsc-fix
• webpack-ugh
• webworkify-1.4.0
• workaround
• worker-error
• worker-refactor
• yarn
• yarn-lock
• yarnify-docs
• yunjieli-animate-a-line
• zoom-expression-validation
• zoom-getters

Build # #1184

Build Type

Pull #3104

circleci

Committed by lucaswoj

Commit Message

Attach marker click listener to map to avoid setTimeout

Pull Request Pull Request #3104: Fix "Marker#togglePopup", refactor "Marker"

Run Details

29 of 29 new or added lines in 3 files covered. (100.0%)

6379 of 7232 relevant lines covered (88.21%)

96355.88 hits per line