manyminds / api2go

80%

master: 81%

LAST BUILD ON BRANCH jsonapi-error-members

branch: jsonapi-error-members

CHANGE BRANCH

x

Reset

• jsonapi-error-members
• 0.3
• 0.4
• 0.5
• 0.6
• 1.0-RC1
• 1.0-RC2
• 1.0-RC3
• 1.0-RC4
• 1067-location-header-item-route
• 274-nested-resource-routes
• HEAD
• apiReturnCodes
• asynchronous-processing
• attributes-optional
• badge-updates
• bugfix-unmarshal-embedded-struct
• bugfix-unmarshaler-interface
• clean_string_fix
• cleanup
• context-package
• coverage
• custom-meta-in-relation
• data-null-response
• default_response
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• different-types-to-many-relationship
• documentation-middleware-context
• documentation_upgrade
• drop-go-17
• dynamic_baseurl_handling
• echo-adapter
• example-create-with-relationships
• export-errors
• fix-crud-documentation
• fix-double-forward-slash
• fix-getFieldByTagName
• fix-tests
• foreignIDintegration
• format-police-coverage
• framework-routing
• github-actions
• go-17-travis
• gofmt_simplify
• handleUpdate-empty-information
• hotfix
• int64ids
• internal-data-structs
• ir-rn-upgrade-deps
• issue-154
• issue_stats
• it-use-gomod-for-gha-versioning
• jsonapi-ignore-tag
• lint-only-on-some-versions
• marshal-composition
• marshal-includes-recursively
• master
• migration_guide
• nested-item-get-route
• nullValueUnmarshal
• patch-id-conflict-error
• private_fields_warning
• readme-httperror
• readme_fixes
• readme_upgrade
• refuse-unsupported-relation-edits
• register-multple-api-versions
• relation-edit-queued-status
• remove-issuestats
• remove-tip
• remove_migration
• report_card
• router_replacement
• security/golang.org-x-net
• sharpner-lint-fix
• sharpner-patch-1
• sparse-fieldsets
• unmarshal-slice-fix
• unmarshaling-array-attributes
• update-dependencies
• update-travis
• v0
• v1

Build # 33357752917

Build Type

Pull #7

Committed by josegonzalez

Commit Message

fix: put the error message in detail and a reason phrase in title

JSON:API defines `title` as "a short, human-readable summary of the problem that SHOULD NOT change from occurrence to occurrence" and `detail` as "a human-readable explanation specific to this occurrence", but `marshalHTTPError` put the per-request message straight into `title` and never sent `detail` at all. It now sends the status code's reason phrase as the title and the message as the detail, omitting the title for a status with no registered phrase. The error for a rejected `fields` query parameter had the same two members inverted and reported a `status` of `Bad Request` where the specification asks for the code, so it is corrected the same way.

Pull Request Pull Request #7:

Coverage Stats

1480 of 1841 relevant lines covered (80.39%)

33.89 hits per line