luser / read-process-memory

89%

master: 86%

LAST BUILD ON BRANCH feature/try-from-refactoring

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 0.1.0
• 0.1.1
• 0.1.2
• cirrus-mac
• master

Build # 40

Build Type

Pull #10

travis-ci

Committed by web-flow

Commit Message

TryFrom refactoring & misc updates

During review of #7, several possible improvements were revealed.
First of all, now that
[TryFrom](https://doc.rust-lang.org/std/convert/trait.TryFrom.html) is
stable, the auxiliary `TryIntoProcessHandle` trait is no longer
needed.

This change
* Refactors the library to use `TryFrom` trait for `Pid ->
  ProcessHandle` and `Child -> ProcessHandle` conversions.

  `TryFrom` trait implementation must reference a type defined in this
  crate, so either `ProcessHandler` or `Pid` had to be converted from
  a type alias to a 1 field tuple.

  It seems like users interact with `ProcessHandle` less often than
  with `Pid`, so converting `ProcessHandle` won't sacrifice ergonomics
  much.

  Example (retrieving the process handle):

  Before:
  ```rust
    let handle = pid.try_into_process_handle()?;
  ```

  After:
  ```rust
    let handle: ProcessHandle = pid.try_into()?;
  ```

* Adds `--verbose` flags to Cirrus CI scripts

* Adds Cirrus CI badge to readme.

* Reconfigures Appveyor CI to use rustup directly, since the old
  script downloaded v1.16 instead of current stable (v1.34)

Pull Request Pull Request #10: TryFrom refactoring & misc updates

Run Details

66 of 74 relevant lines covered (89.19%)

0.89 hits per line