kgoodier / CocoaSPDY

71%

develop: 76%

LAST BUILD ON BRANCH fix/infinite-session-loop

branch: fix/infinite-session-loop

CHANGE BRANCH

x

Reset

• fix/infinite-session-loop
• develop
• develop-future
• develop-next
• develop-next-assert-handler
• develop-qfe
• feature/cellular-metadata
• feature/cellular-metadata-movesession
• feature/code-coverage
• feature/detailed-stream-timings
• feature/fix-metadata-rxbytes
• feature/increase-coverage
• feature/migrate-xctest
• feature/nsurlsession-support
• feature/spdy-push
• feature/spdy-push-develop
• feature/spdy-push-nov
• feature/spdy-push-nov-pre
• feature/spdyassert-handler
• fix/build-warnings
• fix/ci
• fix/proxy-multi
• fix/proxy-simple
• fix/proxy-simple-multi
• fix/release
• fix/socket-crash-fixes
• fix/urlencode-path
• fix/webview-redirects
• ipv6-aliases
• johnkdoe-develop-2
• master
• master-dummy
• no-nil-metadata
• review/absolute-time
• review/http-proxy-pr
• review/increase-code-coverage
• review/increase-code-coverage-squash
• v1.1

Build # 131

Build Type

push

travis-ci

Committed by kgoodier

Commit Message

Fix infinite loop when session disconnects.

Latest refactoring in SPDYSessionManager changed how we allocate
SPDYSessionPool instances. They are now created at init time
and populated when needed, rather than being created and populated
on-demand. Missed the old code that sets the pool to nil when the
last session is removed from it, leading to an infinite loop in
_fillSessionPool.

Run Details

2750 of 3890 relevant lines covered (70.69%)

37.13 hits per line