kgoodier / CocoaSPDY

55%

develop: 76%

LAST BUILD ON BRANCH develop-next-assert-handler

branch: develop-next-assert-handler

CHANGE BRANCH

x

Reset

• develop-next-assert-handler
• develop
• develop-future
• develop-next
• develop-qfe
• feature/cellular-metadata
• feature/cellular-metadata-movesession
• feature/code-coverage
• feature/detailed-stream-timings
• feature/fix-metadata-rxbytes
• feature/increase-coverage
• feature/migrate-xctest
• feature/nsurlsession-support
• feature/spdy-push
• feature/spdy-push-develop
• feature/spdy-push-nov
• feature/spdy-push-nov-pre
• feature/spdyassert-handler
• fix/build-warnings
• fix/ci
• fix/infinite-session-loop
• fix/proxy-multi
• fix/proxy-simple
• fix/proxy-simple-multi
• fix/release
• fix/socket-crash-fixes
• fix/urlencode-path
• fix/webview-redirects
• ipv6-aliases
• johnkdoe-develop-2
• master
• master-dummy
• no-nil-metadata
• review/absolute-time
• review/http-proxy-pr
• review/increase-code-coverage
• review/increase-code-coverage-squash
• v1.1

Build # 65

Build Type

push

travis-ci

Committed by kgoodier

Commit Message

SPDY assertion handler fix.

Apply a custom assertion handler to the NSURL thread that CocoaSPDY
operates on; it will print out the failure and callstack, then call out
to the app via a new delegate in SPDYLogger. The app is expected to
flush logs and crash the app. If the app has not set a logger or does
not implement handleFatalError:, then CocoaSPDY will raise an
NSInternalInconsistencyException exception on the main thread.

This is necessary because an NSAssert, at least in iOS, on the NSURL
thread seems to stop its execution but not kill the process or otherwise
alert the app, as expected by an assertion failure.

Run Details

1779 of 3211 relevant lines covered (55.4%)

24.19 hits per line