kgoodier / CocoaSPDY

71%

develop: 76%

LAST BUILD ON BRANCH feature/fix-metadata-rxbytes

branch: feature/fix-metadata-rxbytes

CHANGE BRANCH

x

Reset

• feature/fix-metadata-rxbytes
• develop
• develop-future
• develop-next
• develop-next-assert-handler
• develop-qfe
• feature/cellular-metadata
• feature/cellular-metadata-movesession
• feature/code-coverage
• feature/detailed-stream-timings
• feature/increase-coverage
• feature/migrate-xctest
• feature/nsurlsession-support
• feature/spdy-push
• feature/spdy-push-develop
• feature/spdy-push-nov
• feature/spdy-push-nov-pre
• feature/spdyassert-handler
• fix/build-warnings
• fix/ci
• fix/infinite-session-loop
• fix/proxy-multi
• fix/proxy-simple
• fix/proxy-simple-multi
• fix/release
• fix/socket-crash-fixes
• fix/urlencode-path
• fix/webview-redirects
• ipv6-aliases
• johnkdoe-develop-2
• master
• master-dummy
• no-nil-metadata
• review/absolute-time
• review/http-proxy-pr
• review/increase-code-coverage
• review/increase-code-coverage-squash
• v1.1

Build # 164

Build Type

push

travis-ci

Committed by kgoodier

Commit Message

Fix rxBytes and rxBodyBytes in metadata.

Data frames were incorrectly reporting their size in the metadata
fields rxBytes and rxBodyBytes. If a data frame got broken up into
multiple TCP segments, those would each be reported to the SPDYSession
as a "data frame", with the encodedLength set to the overall frame
size (for the first segment) or the remaining segment sizes.

It was, essentially, indeterminately wrong from the POV of the app.

Run Details

2778 of 3927 relevant lines covered (70.74%)

44.27 hits per line