k8snetworkplumbingwg / multus-cni
65%
master: 50%

LAST BUILD BRANCH: CORENET-6353
DEFAULT BRANCH: master
Repo Added
Token ci5ZcGVrgFkswX3MaFriGX24zhmxxpDDa regen
Build 1009 Last
Files 26
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH shared-informer
branch: shared-informer
CHANGE BRANCH
x
Sync Branches

coverage: 64.54% (+0.6%) from 63.938%
6186517387

Pull #1154

github

dcbw 
server: don't set CNI config readinessindicatorfile when using ConfigManager

For whatever reason calling os.Stat() on the readiness indicator file
from CmdAdd()/CmdDel() when multus is running in server mode and is
containerized often returns "file not found", which triggers the
polling behavior of GetReadinessIndicatorFile(). This greatly delays
CNI operations that should be pretty quick. Even if an exponential
backoff is used, os.Stat() can still return "file not found"
multiple times, even though the file clearly exists.

But it turns out we don't need to check the readiness file in server
mode when running with MultusConfigFile == "auto". In this mode the
server starts the ConfigManager which (a) waits until the file exists
and (b) fsnotify watches the readiness and (c) exits the daemon
immediately if the file is deleted or moved.

This means we can assume that while the daemon is running and the
server is handling CNI requests that the readiness file exists;
otherwise the daemon would have exited. Thus CmdAdd/CmdDel don't
need to run a lot of possibly failing os.Stat() calls in the CNI
hot paths.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Pull Request #1154: Performance and efficiency improvements in daemon/server mode

149 of 210 new or added lines in 5 files covered. (70.95%)

3 existing lines in 3 files now uncovered.

2246 of 3480 relevant lines covered (64.54%)

16.94 hits per line

Relevant lines Covered
3480 RELEVANT LINES 2246 COVERED LINES
16.94 HITS PER LINE
Source Files on shared-informer

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
6186517387 shared-informer server: don't set CNI config readinessindicatorfile when using ConfigManager For whatever reason calling os.Stat() on the readiness indicator file from CmdAdd()/CmdDel() when multus is running in server mode and is containerized often returns "fi... Pull #1154 dcbw github
64.54
6185877908 shared-informer server: don't set CNI config readinessindicatorfile when using ConfigManager Pull #1154 Dan Williams github
64.54
6176033885 shared-informer server: don't set CNI config readinessindicatorfile when using ConfigManager Pull #1154 Dan Williams github
64.5
6175935444 shared-informer server: don't set CNI config readinessindicatorfile when using ConfigManager For whatever reason calling os.Stat() on the readiness indicator file from CmdAdd()/CmdDel() when multus is running in server mode and is containerized often returns "fi... Pull #1154 dcbw github
64.78
6175818433 shared-informer server: don't set CNI config readinessindicatorfile when using ConfigManager For whatever reason calling os.Stat() on the readiness indicator file from CmdAdd()/CmdDel() when multus is running in server mode and is containerized often returns "fi... Pull #1154 dcbw github
64.53
6167958462 shared-informer github: export and upload e2e test kind logs When things go wrong the logs can help figure out why. Signed-off-by: Dan Williams <dcbw@redhat.com> Pull #1154 dcbw github
64.58
6167692354 shared-informer allow listing Pull #1154 dcbw github
64.66
6167516944 shared-informer github: export and upload kind logs in e2e tests Pull #1154 Dan Williams github
64.66
6167511972 shared-informer server/config: don't render ReadinessIndicatorFile to multus CNI config For whatever reason calling os.Stat() on the readiness indicator file from CmdAdd()/CmdDel() when multus is running in server mode and is containerized often returns "file no... Pull #1154 dcbw github
64.66
6167506514 shared-informer github: export and upload kind logs in e2e tests Signed-off-by: Dan Williams <dcbw@redhat.com> Pull #1154 dcbw github
64.21
See All Builds (504)

Badge your Repo: multus-cni

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh