k8snetworkplumbingwg / multus-cni

63%

master: 56%

LAST BUILD ON BRANCH hostroot-mount-propagation

branch: hostroot-mount-propagation

CHANGE BRANCH

x

Reset

Sync Branches

• hostroot-mount-propagation
• add-netdef-informer
• add-networks-annotation-controller
• add-ready-check
• add-sleep-thin
• add-test-to-capture-flaky-behavior
• add-timeout
• all_capabilities
• AllowTryDeleteOnErrOptions
• allow_undersocre_in_ifname
• auto_confDir
• backport-releasev3-defroute-noifplugin
• bugfix/ensure-resource-is-passed
• bump-netattachdef-client
• bump-ver
• cherry-pick/762
• chore/update-dra-e2e
• chroot
• chroot_test_findpath
• clean-ioutil
• cleanup
• cleanup-multus-conf
• client-lib-multiple-if-cni-result
• cni110
• cni-check-log-message
• cni-daemon-config-does-not-need-shim-socket-path
• code-clean
• codeclean-if
• codeql
• configuration-options-refactor
• crio-mount
• custom_log
• cve-2021-38561
• deads_upstreampick_fallback
• debounce-dial-socket
• default-route-fix-cache-name
• default-route-pointer
• delegateAdd-bug
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/net-0.23.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/google.golang.org/grpc-1.53.0
• dependabot/go_modules/google.golang.org/grpc-1.56.3
• dependabot/go_modules/google.golang.org/protobuf-1.33.0
• detect-python3
• dev/action-update
• dev/add-arm32
• dev/add-cluster-net-name
• dev/add-ut
• dev/chroot
• dev/cleanup-dev-info
• dev/cni100
• dev/delegate-api
• dev/distroless-thin
• dev/doc-modified
• dev/fedora-image
• dev/fix-thick-e2e
• dev/go118
• dev/metrics
• dev/no-cniversion
• dev/nosetenv
• dev/rc-api
• dev/refine-build
• dev/refine-config
• dev/refine-e2e
• dev/refine-k8s-lib
• dev/refine_multus_ut
• dev/refine-multus-ut
• dev/remove-old-conf
• dev/remove-restart-crio
• dev/simple-kubeletpkg
• dev/simplify-dockerfile
• dev/update-golang
• dev/update-golang119
• dev/update-layout
• dev/update-lib
• dev/use-ghcr
• dev/use-non-default-libcni-cache
• disable-dra-e2e-temporarily
• doc-clusternetwork
• docker-updates
• docs-thick-plugin-config-update
• downgrade-k8s-vendor
• downwardapi
• dra
• e2e-kind-logs
• e2e-tests-always-pull-new-imgs
• e2e-update
• enable_bandwidth
• enable-events-on-e2e-tests
• entrypoint-refresh-kubeconfig
• entrypoint.sh
• example-pod
• exec_chroot_test
• failure-logs
• feature/multus-4.0
• fix/1126
• fix/1130
• fix-1186
• fix/773
• fix/948
• fix/add-disclaimers
• fix-archived-package
• fix/change-image-url
• fix/change-org-name
• fix/chroot
• fix/cleanup-code
• fix/cmddel
• fix_CmdDel
• fix/cmddel-nostatus-update
• fix/cni-bin-dir
• fix/default-route
• fix/delegate-api
• fix/delete_old_main
• fix/del-noerr
• fix-e2e
• fix_entrypoint
• fix/filepath
• fix/fix-sliceindex
• fix_flag_usage
• fix-flaky-config-regen-test
• fix/gateway-nil
• fix/go-mod-tidy
• fix/goreleaser
• fix/image
• fix/image-tag
• fix-legacy-entrypoint-e2e-tests
• fix-letter
• fix/license-boilerplate
• fix/liner-warning
• fix-logging
• fix/m40-revive-err
• fix/mod-ver
• fix-mount-prop-var-lib-kubelet
• fix_multiple_default_gw
• fix/no-network-error
• fix/okd-build
• fix/opt-out-mount-sa
• fix-panic-arr
• fix-params
• fix/path-injection
• fix/plugin-without-interface
• fix-race-condition
• fix-readiness
• fix-readiness2
• fix/reload-kubeconfig-if-failed
• fix/remove-global
• fix/remove-origin
• fix/remove-origin-build
• fix-retry
• fix/revive
• fix/revive-err
• fix/server
• fix/so-long-gorilla
• fix/sriov
• fix-strings-split
• fix/thick-log-options
• fix-type-scope-comment
• fix-typo
• fix-typos
• fix/update-nad-lib
• fix_url
• fix/use-multus-install
• fix/version
• fix/warning
• format-code
• getlivepod
• ginkgov2
• golang-e2e-tests
• health-endpoint-thick-plugin
• idiomatic-config-unit-tests
• improve-v4-config
• jk_readme_thick_plugin
• kubeconfig-atomic-move
• kubelet_socket
• manifest-toleration
• master
• master_cni_file
• multus40-prefer-configmap
• multus40-startup-tweaks
• multus-4-docs-thickplugin-default
• nanafix
• net-attach-def-client-v172
• net-attach-def-client-v173
• net-attach-def-client-v174
• net-attach-def-lib-175
• netns-cni-del
• no-dproxy
• notice
• no-vendor
• opt_error
• optionally-process-specific-network-interface
• origin_build
• param-config-watcher-interval
• patch-1
• patch-2
• patch-3
• patch-4
• per-node-cert
• podman-kind-cluster
• pod-uid
• poduid-cni-del-path
• pollimmediate-errormsg
• pr-1302-update
• print-kubeconfig
• quick-start
• readme-updates
• recreate-configs-on-file-change
• refine-build
• refine-options
• refs/tags/v3.7.1
• refs/tags/v3.7.2
• refs/tags/v3.8
• refs/tags/v3.8.1
• refs/tags/v3.9
• refs/tags/v3.9.2
• refs/tags/v3.9.3
• refs/tags/v4.0.0
• refs/tags/v4.0.0-alpha
• refs/tags/v4.0.1
• refs/tags/v4.0.2
• refs/tags/v4.0-alpha
• refs/tags/v4.1.0
• refs/tags/v4.1.1
• refs/tags/v4.1.2
• refs/tags/v4.1.3
• release-policy
• release-v3
• remove-extra-mnt-point-thick
• remove-readiness-check-on-del
• remove-status-set-del
• remove-unused-cni-args
• replace-entrypoint-script-with-initcontainers
• resource_api
• resource_api_grpc
• retry-on-multiple-error-types-with-backoff
• returnlogging
• Sagit-chu-patch-1
• save-informer-memory
• set_timeout
• shared-informer
• skip-api-ready-on-cni-del
• slack-invite
• stale-issues
• stale-kubeconfig-hash
• static-pod-e2e
• supplment_log_for_stdindata
• support_mtu
• test
• test-gh-ci
• test-go
• test_go_path
• test-macvlan
• test-multi-if-cni-result-gateway-marking
• testsh
• thick-arch
• thick-arm
• thick-atomic-config-write
• thickplugin_graceful_term2
• thick-readiness
• thin
• thin-master-cni-file-flag
• tryDelegate
• update-e2e
• update_e2e_tools
• update-gh-action
• update-golang
• update_golang_version
• update-go-version
• update-kind
• update-libcni
• update-net-attach-client
• update-net-attach-client-v3
• upgrade-fsnotify
• upstream-sync-redux-4.8
• use-same-base-image
• v1beta1
• yulng-e2e-readme

Build # 9291526752

Build Type

Pull #1290

github

Committed by dougbtv

Commit Message

This pull request modifies the volume mount propagation for the `hostroot` volume in the `multus-daemonset-thick.yml` example/quickstart deployment file from `HostToContainer` to `Bidirectional`. This change enables the volume to be accessible in both directions, which is necessary for users who need to share a mount with another container/pod.

This is motivated by the fact that in thin plugin mode, since all things were run on the host directly, CNI plugins wouldn't be limited by the mount propagation.

One example that has come up recently is userspace CNI interaction with kubevirt, and sharing the usage of the socket as mounted by kubevirt.

This does expose some level of risk (as noted in the mount propagation docs regarding changing of mounts), however, I don't believe it's significantly more than would've been the case in thin plugin mode.

References
- [Kubernetes Volume Mount Propagation Documentation](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation)

Pull Request Pull Request #1290: Bidirectional mount propagation for hostroot

Run Details

2293 of 3633 relevant lines covered (63.12%)

16.69 hits per line