johnyf / dd

81%

master: 88%

LAST BUILD ON BRANCH v0.4.0

branch: v0.4.0

CHANGE BRANCH

x

Reset

• v0.4.0
• abc
• comparison
• dev
• dev_0.4.3
• dev_0.5.0
• master
• rename
• reordering
• sylvan
• test_0.4.2
• travis
• travis_ci
• v0.0.2
• v0.0.3
• v0.0.4
• v0.1.0
• v0.2.0
• v0.2.1
• v0.2.2
• v0.3.0
• v0.3.1
• v0.4.1
• v0.4.2
• v0.4.3
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.3
• v0.5.4

Build # 111

Build Type

push

travis-ci

Committed by johnyf

Commit Message

BUG: use `list` of `tuple`s instead of `dict` for parsing renaming pairs

because `astutils.ast.Terminal` is a user-defined class,
but defines `__eq__` and not `__hash__`.
So, it is incorrect to use instances as keys.

Moreover, this is a python 2 weakness.
In python 3, it raises an exception.
The documentation of `object.__hash__` reads [1]:

"A class that overrides __eq__() and
does not define __hash__() will have its __hash__()
implicitly set to None."

[1] https://docs.python.org/3/reference/datamodel.html#object.__hash__

Run Details

3072 of 3804 relevant lines covered (80.76%)

0.81 hits per line