igrigorik / http-2

97%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

• master
• v0.7.0
• upgrade
• v0.8.0
• v0.8.1
• v0.8.2
• purge_closed_streams
• v0.8.3
• v0.8.4
• v0.9.0
• v0.9.1
• strict-mode
• v0.10.0
• v0.10.1

Build # 363

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Fix cleaning up recently closed streams (#152)

* Fix cleaning up recently closed streams

Ever since 16dec9f2c in 2018
@streams_recently_closed cleanup was broken.

`to_delete` contains hash of { stream_id => time } so in
`to_delete.each do |stream_id|` `stream_id` is actually array of `[
stream_id, time ]`.

This leads to the same memory leak as there was before the first cleanup
but also adds heavy CPU usage when thousands of streams are being
checked on every stream close.

Since 15s delayed cleanup was intended but actually infinite delay was
added so 15s was never tested in production code and thus might be not
enough.

This change also improves performance of searching streams to delete by
relying on the fact that Ruby Hash is ordered and so once fresh stream
was met we can stop searching.

Also minor performance and memory improvement by storing only timestamp
instead of Time object.

Extracted this part of the code to a separate function for test
convenience.

* Remove Bundler version dependency

Bundler version isn't really important everything installs fine for
testing with latest bundler, but it fails on CI for later rubies

Co-authored-by: Ilya Kaplan <ilya@seekingalpha.com>

Run Details

2563 of 2635 relevant lines covered (97.27%)

9500.6 hits per line