iconara / ione

100%

master: 99%

LAST BUILD ON BRANCH stack-safe-reduce

branch: stack-safe-reduce

CHANGE BRANCH

x

Reset

• stack-safe-reduce
• 1.2.0.pre4
• acceptor-host-and-port
• after-factory
• byte-buffer-getbyte
• byte-buffer-index
• deprecate-future-value
• destructive-future-combinators
• fix-jruby-test-issues
• fix-warnings
• future_improvements
• handle_badf_in_select
• http_server
• improve-base-connection-locks
• io-reactor-drain
• master
• optimize-resolved-combine
• optimize_future_combinators
• optimized_scheduler
• restartable_reactor
• running-while-stopping
• ssl_support
• ssl_support_on_1.2
• stack-safe-after
• streams
• synchronized_close
• thread-pooling
• travis-test
• travis_debug
• try-complete-promise
• unblock-once
• uncaught-error-handler
• v1.0.0
• v1.1.0
• v1.1.0.pre0
• v1.1.1
• v1.1.2
• v1.1.3
• v1.1.4
• v1.1.5
• v1.1.x
• v1.2.0.pre0
• v1.2.0.pre1
• v1.2.0.pre2
• v1.2.0.pre3
• v1.2.0.pre4
• v1.2.0.pre6
• v1.2.0.pre7
• v1.2.0.pre8
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.x
• v1.3.0.pre0
• v1.3.0.pre1
• v1.3.0.pre2

Build # 220

Build Type

push

travis-ci

Committed by grddev

Commit Message

Avoid stack overflow error with Future.reduce

This completely splits the implementation between the ordered and
unordered reduce, as it becomes rather difficult to share code between
the two.

This tweaks the internal interface slightly, in particular by not using
an instance variable for the accumulator in either case.

With a long list of resolved futures, the previous implementation of an
ordered reduce caused a stack-overflow exception, as each call to
reduce_next happened within the previous call (synchronously).

This changes the behavior to loop over futures instead of using
recursion while on_complete dispatches synchronously in the same thread.
The implementation is heavily based on the non-recursive implementation
of Future.after

Run Details

2629 of 2636 relevant lines covered (99.73%)

19257.42 hits per line