iconara / ione

99%

master: 99%

LAST BUILD ON BRANCH fix-jruby-test-issues

branch: fix-jruby-test-issues

CHANGE BRANCH

x

Reset

• fix-jruby-test-issues
• 1.2.0.pre4
• acceptor-host-and-port
• after-factory
• byte-buffer-getbyte
• byte-buffer-index
• deprecate-future-value
• destructive-future-combinators
• fix-warnings
• future_improvements
• handle_badf_in_select
• http_server
• improve-base-connection-locks
• io-reactor-drain
• master
• optimize-resolved-combine
• optimize_future_combinators
• optimized_scheduler
• restartable_reactor
• running-while-stopping
• ssl_support
• ssl_support_on_1.2
• stack-safe-after
• stack-safe-reduce
• streams
• synchronized_close
• thread-pooling
• travis-test
• travis_debug
• try-complete-promise
• unblock-once
• uncaught-error-handler
• v1.0.0
• v1.1.0
• v1.1.0.pre0
• v1.1.1
• v1.1.2
• v1.1.3
• v1.1.4
• v1.1.5
• v1.1.x
• v1.2.0.pre0
• v1.2.0.pre1
• v1.2.0.pre2
• v1.2.0.pre3
• v1.2.0.pre4
• v1.2.0.pre6
• v1.2.0.pre7
• v1.2.0.pre8
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.x
• v1.3.0.pre0
• v1.3.0.pre1
• v1.3.0.pre2

Build # 287

Build Type

push

travis-ci

Committed by iconara

Commit Message

Use just one barrier in the test that blocks

I think the problem is that the reactor is not in select when #stop is called, so it just skips to the stopping phase directly. With this test implementation the reactor will be blocked when #stop is called, and the test will kind of test that it continues running until the future resolves.

It's not a great test to say the least.

Run Details

2743 of 2776 relevant lines covered (98.81%)

94.99 hits per line