grondo / flux-core

72%

master: 80%

LAST BUILD ON BRANCH issue#423

branch: issue#423

CHANGE BRANCH

x

Reset

• issue#423
• 0.1.0
• 0.9.0-news
• CID-135611
• NEWS
• README
• active_jobs
• aggregator
• aggregator-generalize
• aggregator-jansson
• autogen-update
• autotools
• ax_valgrind
• buffer-watcher-close
• chain-lint
• check-code-coverage-fix
• cherry-pick-rebase-pull-request-3-7c65ded4-944b-4c3a-8e00-ed2b4fd71d98-b8e939d0-a398-47dc-b90f-81ca7bbc3c71
• cleanups
• cmddriver-fixes
• codecov
• composite_futures
• config-tmpfixes
• config_simplify
• coverage
• coverage2
• coverity-fixes
• coverity_scan
• cppcheck
• cron
• cron-jansson
• cron2
• cronodate
• cronodate-pr-fixups
• cronodate-testing
• cuda_visible_devices
• deploy-avoid-glob
• deploy-fix
• deploy-test
• dirwalk
• dirwalk-corner-cases
• event-trace
• extensor
• fix-make-clean
• flux-help
• flux-hostlist
• flux-object-proto
• flux-opts
• flux-start--wrap
• flux-version
• fluxometer-installed
• gcc-8
• hello-leak
• hwloc-byrank-hostname
• hwloc-lstopo
• hwloc-walk-topo
• imp_prototype
• includes-order
• installed-tests-fixes
• issue#1062
• issue#1097
• issue#1101
• issue#1121
• issue#1179
• issue#1250
• issue#1251
• issue#1280
• issue#1356
• issue#1366
• issue#1370
• issue#1379
• issue#1416
• issue#1491
• issue#1504
• issue#1592
• issue#1638
• issue#22
• issue#415
• issue#426
• issue#435
• issue#444
• issue#448
• issue#522
• issue#549
• issue#569
• issue#612
• issue#655
• issue#676
• issue#696
• issue#808
• issue#821
• issue#828
• issue#900
• issues-cleanup
• job-fu
• job-fu-orig
• jsc-leaks
• jsc-lru-cache
• kvs-restore
• lstopo
• lstopo-working
• lua-5.2
• lua-5.2-test
• lua-error-checks
• lua-fixups
• lua-getattr
• lua-jansson
• lua-test-fixes
• lua-watchers
• lwj-active
• lwj-hierarchy
• master
• minifixes
• minor-wreck-updates
• minus-o-mpi
• modloader
• more-coverage
• more-testing-updates
• mpi-plugin-fixups
• multiuser-hwloc
• my-wednesday-tangent
• news-0.10
• news-0.7.0
• news-0.8.0
• optparse-fixups
• optparse-flags
• optparse-improve
• optparse-improvements
• optparse-posixly_correct
• optparse-reentrant
• optparse-reentrant2
• optparse-subcmd-noopts
• path-prepend
• pmi-async-kvs
• purge-keep
• pylint-disable
• rcalc-fixes
• relnotes
• remove-approxidate
• rfc11-final
• small-fixes
• splash-fixes
• stdin
• stdin-links
• stdin-test
• stdio-to-files
• subcmd
• subprocess
• systemd-tweaks
• t
• t5000-valgrind-fix
• task-affinity
• tau-tracing
• test
• test-fixes
• test-mpi
• test_under_flux
• testsuite-robustness
• travis-autotool-update
• travis-coredumps
• travis-dep-cache-fix
• travis-fixes
• travis-mitigate
• travis-mitigation
• travis-refresh
• travis-testing
• travis-updates
• trws-tracing
• v0.3.1
• v0.3.2
• valgrind.supp
• waitfile
• waitfile-test-fixes
• waitfile-tests-updates
• watchers
• wreck-aggregate
• wreck-cancel
• wreck-cancel-fixup
• wreck-cmb.exec
• wreck-cts1
• wreck-epilog
• wreck-experimental
• wreck-hostlist
• wreck-pmi-simple
• wreck-setenv
• wreck-test-fixes
• wreck-timeout
• wrexecd-affinity
• wrexecd-cleanup
• wrexecd-jansson
• zio-cleanup

Build # 424

Build Type

push

travis-ci

Committed by grondo

Commit Message

bindings/lua: fix crash in lua_push_flux_handle

Under at least one version of Lua 5.1 an assertion was being
triggered in lua_push_flux_handle() when under use by the lua
plugins in wrexecd. The invariant that was violated was that
the "flux" entry existed in the flux reftable, but the userdata
pointer to the real flux_t handle was invalid.

It is unclear why this was happening, but may be due to the
local/global/coroutine shenanigans used in luastack.c to
run multiple plugins against the same global state.

In this case, it is safe to recreate the flux_t userdata, so instead
of asserting here just fall through if no userdata found.

Fixes #423.

Run Details

14867 of 20708 relevant lines covered (71.79%)

203821.81 hits per line