grobidOrg / grobid

43%

master: 43%

LAST BUILD ON BRANCH feature/training-xml-t

branch: feature/training-xml-t

CHANGE BRANCH

x

Reset

Sync Branches

• feature/training-xml-t
• 0.9.0
• bugfix/add-priority-content-type
• bugfix/avoid-IOBE-in-orcid-search
• bugfix/codespell-round-two
• bugfix/correct-git-revision
• bugfix/docker-arm
• bugfix/docker-full-build
• bugfix/fix-149
• bugfix/fix-15
• bugfix/fix-671
• bugfix/fix-728
• bugfix/fix-849
• bugfix/fix-classification-delft
• bugfix/fix-doi-search
• bugfix/glutton-healthcheck-path
• bugfix/improve-regexes
• bugfix/issue-1024
• bugfix/issue-1355
• bugfix/issue-271
• bugfix/issue-465
• bugfix/issue-512
• bugfix/issue-716
• bugfix/issue-849
• bugfix/issue-920
• bugfix/jep-env-uv
• bugfix/jep-shutdown-deadlock
• bugfix/model-selection-flavours
• bugfix/patch-lmdb
• bugfix/reference-segmenter-createTraining
• bugfix/sentence-segmentation-detection
• bugfix/spotless
• bugfix/support-missing-dir
• bugfix/ziputils-security-advisor
• bugfixes/docker-retag
• bugix/correct-revision
• chore/dependabot
• chore/remove-powermock
• chore/remove-unused-models
• ci/reduce-coveralls
• ci/release-automation
• ci/support-forks
• copilot/fix-founders-extraction-issue
• copilot/fix-null-pointer-exception
• copilot/fix-paragraph-segmentation-issue
• copilot/fix-tokenizer-language-sensitivity
• copilot/fix-wapiti-jni-space-argument
• copilot/improve-article-metadata-merging
• copilot/make-evaluation-friendlier
• copilot/possibility-to-list-ongoing-trainings
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/actions/setup-java-5
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/docker/build-push-action-7
• dependabot/github_actions/docker/login-action-4
• dependabot/github_actions/docker/setup-buildx-action-4
• dependabot/github_actions/github/codeql-action-4
• dependabot/github_actions/gradle/actions-6
• dependabot/github_actions/mikepenz/action-junit-report-6
• display-version-in-ui
• docs/improvements
• feature/add-api-status-in-ui
• feature/add-code-cleaning
• feature/add-ignore-areas-api
• feature/add-pdf-tei-editor
• feature/affiliation-linked-evaluation
• feature/apache-licence-header
• feature/auto-update-hf-space
• feature/blingfire
• feature/code-formatting
• feature/codeql
• feature/codespell
• feature/coi-ac
• feature/coi-ac-update-light-models
• feature/community-page
• feature/development-api
• feature/docker-summary
• feature/documentation
• feature/extract-any-url-in-fulltext
• feature/fix-bibtex-index
• feature/improve-actions
• feature/improve-documentation
• feature/issue-to-documentation
• feature/literature-law-flavour
• feature/literature-law-flavour-eval
• feature/literature-law-flavour-experiment
• feature/literature-law-flavour-experiments
• feature/middle-name-bibtex
• feature/onnx-models
• feature/onnx-models-perf
• feature/onnx-models-perfs
• feature/otlp-metrics-push
• feature/prepare-release
• feature/refactor-tei-formatter
• feature/refactor-trainers
• feature/remove-unused-lexicons
• feature/rename-ui-items
• feature/revise-consolidation
• feature/rewrite-overloaded
• feature/sync-crf-manual-build
• feature/unpin-lmdb-delft
• feature/update-benchmarks
• feature/update-copyright
• feature/update-delft
• feature/update-dependencies
• feature/update-doc-flavor-dev
• feature/update-editorconfig
• feature/update-lingua
• feature/use-outline-to-structure-head
• feture/update-documentation
• fix/pdfalto-memory-limit-macos
• hotfix/0.9.0-docker
• improvement/affiliation-author
• improvement/fix-lexicon
• improvements/fails-on-failures
• improvements/speed-up-ci
• master
• multi-arch-docker-image
• publish/0.9.0-central
• release/0.9.0
• rootless
• rootless-docker
• security/cmdinjection-threadleak
• security/jline-cmdinjection-threadleak
• security/update-dependencies
• tensorflow-2.16
• tensorflow-2.16-docker-full

Build # 29514855442

Build Type

Pull #1508

github

Committed by lfoppiano

Commit Message

fix: do not prepend the underscore to training file names, only to xml:id

The leading underscore is an NCName constraint that only applies to the
xml:id values in the generated TEI. Split TextUtilities.sanitizeXmlId
into sanitizeFileName (character replacement only), used for the
training file names, and sanitizeXmlId which additionally prepends the
underscore when the name starts with a character not allowed as first
NCName character. Trainers resolving the feature file from the xml:id
strip the leading underscore, as TEIHeaderSaxParser.getPDFName already
does.

Signed-off-by: Luca Foppiano <luca@foppiano.org>

Pull Request Pull Request #1508: Make the xml:id of the training generated files a valid NCName

Coverage Stats

9841 of 25340 branches covered (38.84%)

Branch coverage included in aggregate %.

20524 of 46066 relevant lines covered (44.55%)

1.8 hits per line