griffithlab / civic-server

88%

master: 16%

LAST BUILD ON BRANCH trigger-mentions-for-sources

branch: trigger-mentions-for-sources

CHANGE BRANCH

x

Reset

• trigger-mentions-for-sources
• 787-user-country
• HEAD
• aacr-perf-fixes
• add-doi-badge
• add-id-to-source-search
• add-lib-to-eager-load
• additional-flagged-values
• adv_search
• advanced_search
• allele_registry
• allele_registry_ca
• amp
• array_agg
• asco
• asco_bugfix
• asco_search
• assertion_search
• assertion_stats
• assertions
• assertions-lifecycle-update
• assertions_tsv
• attach-org-to-user-context
• biological_evidence
• bool_cast
• browse
• browse-grid-filter-bug
• browse_filter
• bugfix_pubmed
• caid
• cap-sidekiq
• capture-event-status
• case-insensitive-sort
• changes_state_params
• civic_score
• civicpy
• civicpy_error
• civicpy_vcf
• cleanup-unused-dirs
• clinical_trial_search
• clinical_trials
• clone-subscriptions
• coi
• conflict-of-interest
• cors-headers
• delete-tool
• dependabot/bundler/kaminari-1.2.1
• dependabot/bundler/kramdown-2.3.0
• dependabot/bundler/loofah-2.3.1
• dependabot/bundler/nokogiri-1.10.8
• dependabot/bundler/rack-2.0.8
• dependabot/bundler/rack-cors-1.0.5
• dependabot/bundler/sanitize-5.2.1
• dependabot/bundler/websocket-extensions-0.1.5
• dependency-updates
• disease
• disease_ontology
• dominant_negative
• drug_endpoint
• drug_interaction
• drugs
• duplicate_sources
• empty-string-to-null
• event_feed
• event_timestamp
• evidence_direction
• feature/org-parent
• feature/org-parent-1
• fix-badge-awards
• fix-browse-grid-sorting
• fix-concurrency-issue
• fix-eager-load-error
• fix-eid-counts
• fix-escalating-retries
• fix-hpo-link
• fix-invalid-link-styles
• fix-source-citation-display
• fix-sql-quoting
• fix-stats-hashes
• flag
• flag-badges
• flag-resolution
• flag-status
• flags
• functional
• gene_exact_match
• gene_lifecycle
• graphql-experiment
• groups
• handle-commas
• handle-rate-limit
• handle-routing-error
• hotfix
• hotfix_browse_filtering
• hotfix_jobs
• hpo
• id_links
• improve-drug-suggestions
• include-assertions-in-counts
• issue_1140
• issue_1143
• issue_1200
• issue_1255
• issue_1264
• issue_1268
• issue_1272
• issue_1274
• issue_1276
• issue_908
• issue_912
• jobs
• journal
• lambda
• lifecycle_org
• link-changes-to-frontend
• links
• mane_transcript
• master
• merge_disease
• merge_variants
• multi_org
• multi_user_org
• myvariant_info
• nccn_guideline
• ndex
• notify-admins-on-editor-mention
• null-disease-url
• org
• org_bugfixes
• org_stats
• organization
• organization-counts
• orgs
• pipeline_type
• publication-scraping-hotfix
• pull-ndex-creds-from-secrets
• python_37
• reject-your-own-submissions
• release
• releases
• remove-self-schedule
• resque
• revert-eid
• revision_stats
• sanitized-sql
• scheduling-fixes
• scoped-event-feeds
• search-pagination
• setup-airbrake
• simplify-query
• so
• soid_search
• source
• source-type-description
• source_adv_search
• source_validation
• staging
• stats-improvements
• strip-internal-whitespace
• suggested_change
• throttle-requests
• training-server
• travis
• tsv
• tsv_dump
• uniprot
• update-deps
• update-github-auth
• update-python-install
• updtime-lambda
• uptime-fixes
• user-image-upload
• user_error
• user_filter
• user_update
• v1.0.0
• variant-group-lifecycle-hotfix
• variant_group
• variant_group2
• variant_origin
• variant_search
• variant_type
• vcf_releases

Build # 1550

Build Type

Pull #443

travis-ci

Committed by web-flow

Commit Message

Mentions in source suggestions trigger notifications

These previously weren't working because comments on source suggestion
submissions aren't "real" comments, just a text field on the actual
SourceSuggestion entity. Ideally we'd refactor it so that they were
real Comment entities, but that's slightly more involved. For now, this
makes it so that the NotifyMentioned background job can accept arbitrary
text and an Event instead of a Comment and an Event, which works in both
cases.

Pull Request Pull Request #443: Mentions in source suggestions trigger notifications

Run Details

5 of 5 new or added lines in 2 files covered. (100.0%)

1710 of 1949 relevant lines covered (87.74%)

3.03 hits per line