google / go-jsonnet

44%

master: 44%

LAST BUILD ON BRANCH rudo.thomas/fix-cached-import-syntax-error

branch: rudo.thomas/fix-cached-import-syntax-error

CHANGE BRANCH

x

Reset

• rudo.thomas/fix-cached-import-syntax-error
• add-clamp-to-linter
• bazelfixes
• bazelisk
• bugfix/setuptools-72
• build_cleanup
• ci-check-bzlversions
• digitsep
• error-test-for-manifestYamlDoc
• feat/csv
• feat/is-null
• fix-linter-manifest-json-ex
• fix-linter-multiple-snippets
• fix-manifestYamlDoc-error-check
• fix-minArray-maxArray-keyF
• fix-negative-range
• fix-parse-yaml
• fix_807_removeAt
• go-mod-version
• master
• mcarl/fix-oob-formatter
• no-libjsonnet-h
• optional-symlinks
• output-newline
• patch-1
• prepare-release
• python-release-gil
• pywheels
• readme-updates
• remove-key
• rudo-fix-comprehension-over-string-error-message
• security-doc
• table-test-number
• update-ci
• update-cpp-jsonnet
• update-cpp-script
• update-dependencies
• update-go-deps
• update-project-status
• use-local-test-overrides
• v0.10.0
• v0.16.0
• v0.17.0
• yihao/bazel-example

Build # 21405639767

Build Type

Pull #823

github

Committed by johnbartholomew

Commit Message

fix(imports): Cache the error too in importAST().

The bug was that a non-nil error was not returned when the cached Node
was returned. Fix: Just cache both.

The other possibility was not to cache when there is an error. But that
broke a test in the linter.

Fixes https://github.com/google/go-jsonnet/issues/822

Pull Request Pull Request #823: fix(imports): Cache the error too in importAST().

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

6009 of 13605 relevant lines covered (44.17%)

1429.77 hits per line