google / go-jsonnet

44%

master: 44%

LAST BUILD ON BRANCH fix-manifestYamlDoc-error-check

branch: fix-manifestYamlDoc-error-check

CHANGE BRANCH

x

Reset

• fix-manifestYamlDoc-error-check
• bazelfixes
• bazelisk
• bugfix/setuptools-72
• build_cleanup
• error-test-for-manifestYamlDoc
• feat/csv
• fix-minArray-maxArray-keyF
• go-mod-version
• master
• mcarl/fix-oob-formatter
• no-libjsonnet-h
• prepare-release
• python-release-gil
• pywheels
• readme-updates
• rudo-fix-comprehension-over-string-error-message
• update-ci
• update-cpp-script
• update-dependencies
• update-go-deps
• update-project-status
• v0.10.0
• v0.16.0
• v0.17.0

Build # 15758213335

Build Type

Pull #800

github

Committed by johnbartholomew

Commit Message

fix: Unchecked error in std.manifestYamlDoc().

Problem: A recursive call within manifestYamlDoc() might fail but the
return value is not checked.

Reproducible with:
```
$ jsonnet-2f73f61 -e "std.manifestYamlDoc({ x: { y: error 'foo' } }, quote_keys=false)"
"x:\n  "
```

Expected:
```
$ jsonnet-0.20.0 -e "std.manifestYamlDoc({ x: { y: error 'foo' } }, quote_keys=false)"
RUNTIME ERROR: foo
	<cmdline>:1:31-42	object <anonymous>
	...
```

Pull Request Pull Request #800: fix: Unchecked error in std.manifestYamlDoc().

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

1567 existing lines in 22 files now uncovered.

5991 of 13600 relevant lines covered (44.05%)

1424.62 hits per line