go-sql-driver / mysql

83%

master: 83%

LAST BUILD ON BRANCH fix/result-empty-slice-panic

branch: fix/result-empty-slice-panic

CHANGE BRANCH

x

Reset

• fix/result-empty-slice-panic
• 1.8
• 1.9
• ErrShortWrite
• InterpolateParams
• add-charset
• atomic
• auth_refactoring
• auth_tests
• authentication
• backport-bench-1.9
• binary-littleendian
• bump-mysql-for-testing
• changelog
• clientDeprecateEOF
• cloudsql
• columntype
• compression
• conncheck-alloc
• conncheck_platforms
• connncheck_optional
• contributing
• copilot/consolidate-dependabot-prs
• copilot/support-rows-column-scanner
• copilot/update-go-version-1-24-to-1-26
• copyright
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/dominikh/staticcheck-action-1.4.1
• dependabot/github_actions/github/codeql-action-4
• dependabot/go_modules/filippo.io/edwards25519-1.2.0
• dolthub/master
• dsn_defaults
• empty_auth
• empty_sha256
• fil-register-set
• fix-1666
• fix-bench-massiverows
• fix-flaky-test
• fix-getSystemVar-buffer-reuse
• fix-gomod
• fix-race-condition-of-test-concurrent
• fix-staticcheck
• fix-test
• fix-test2
• fix-unused-benchmarkExecContext
• fix/ParseDSN-colon-in-username
• fix/newconfig-default-net
• fix_bigint_unsigned_scan_type
• fix_comment_typo
• fix_formatdsn_connectionattributes
• flaky_tests
• fmt
• formatdsn_err
• go-mod
• go1.19-is-released
• go1.21-and-mysql8.1-are-released
• go1.24-is-released
• go110
• handle_error_packets
• internal
• introduce-run-tests-parallel
• mariadb-test-update
• mark-as-helper
• master
• max-allowed-packet-parsing
• max_allowed_packet
• metadataSkip
• methane-patch-1
• migrate-set-output
• migrate-to-node16-actions
• misc_fixes
• modernize
• modernize-2025-11-06
• opt-read
• opt-read-19
• patch-1
• prepare-for-v1.7.0
• private-query-tracer
• purego
• read_opt
• read_optimization
• readme_collation
• refs/tags/v1.10.0
• refs/tags/v1.6.0
• refs/tags/v1.7.0
• refs/tags/v1.7.1
• refs/tags/v1.8.0
• refs/tags/v1.8.1
• refs/tags/v1.9.0
• refs/tags/v1.9.1
• refs/tags/v1.9.2
• refs/tags/v1.9.3
• regression801
• release-1101
• release-v190
• release-v191
• release-v193
• return-original-error-from-transaction
• reuse-metadata
• revert-976-master
• sha256_password
• staticcheck
• strict
• tls-mysql5-docs
• tls-security
• tlsconfig
• travis
• travis-allow-failure
• travis-crossbuild
• travis-mysql8
• travis-update
• tx-19
• update-internals-links
• v1.4
• v1.4.0
• v1.4.1
• v1.5.0

Build # 26049355567

Build Type

Pull #1769

github

Committed by c-tonneslan

Commit Message

result: don't panic when affectedRows/insertIds are empty

Closes #1733.

mysqlResult.LastInsertId / RowsAffected indexed into their slices
without checking length, so any code path that left the result slices
empty (e.g. an error before the affected-rows packet) panicked the
caller. Return 0, nil instead, which matches the database/sql.Result
contract for 'no rows affected'.

Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>

Pull Request Pull Request #1769: result: don't panic when affectedRows/insertIds are empty

Coverage Stats

6 of 0 new or added lines in 0 files covered. (NaN%)

3384 of 4091 relevant lines covered (82.72%)

2621745.87 hits per line